Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

ENH: Add location parameter to read_gbq and to_gbq#185

Merged
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue-177-location
Jun 11, 2018
Merged

ENH: Add location parameter to read_gbq and to_gbq#185
tswast merged 3 commits intogoogleapis:masterfrom
tswast:issue-177-location

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Jun 8, 2018

This allows queries to be run against datasets in the Tokyo region.
Likewise, it enables loading dataframes into Tokyo datasets.

The location parameter was added in 0.32.0, so this PR also updates the
minimum google-cloud-bigquery version.

Towards #177

This allows queries to be run against datasets in the Tokyo region.
Likewise, it enables loading dataframes into Tokyo datasets.

The location parameter was added in 0.32.0, so this PR also updates the
minimum google-cloud-bigquery version.
@tswast tswast requested review from max-sixty and parthea June 8, 2018 23:06
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Jun 8, 2018

Fix test to use private_key parameter so that it passes on Travis.
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Jun 8, 2018

Bah, conda is broken again. Probably because of namespace packages. I'll revert my change that updated the conda google-cloud-bigquery version and see if that fixes it.

Comment thread tests/system/test_gbq.py
FROM UNNEST(GENERATE_ARRAY(0,5,1)) as r
""".format(tokyo_dataset, table_id),
location='asia-northeast1').result()
return table_id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Copy Markdown
Contributor

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some nice clean ups too 🤗

@tswast tswast merged commit e7007a8 into googleapis:master Jun 11, 2018
@tswast tswast deleted the issue-177-location branch June 11, 2018 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants