feat: include key metadata in Job representation #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
plamut
commented
Sep 13, 2021
Comment on lines
+727
to
+729
| f"{self.__class__.__name__}<" | ||
| f"project={self.project}, location={self.location}, id={self.job_id}" | ||
| ">" |
Contributor
Author
There was a problem hiding this comment.
Note - I chose chevrons over parentheses so that the repr string does not appear as something eval()-able, as it's often the case with repr() output.
tswast
approved these changes
Sep 13, 2021
Comment on lines
+727
to
+729
| f"{self.__class__.__name__}<" | ||
| f"project={self.project}, location={self.location}, id={self.job_id}" | ||
| ">" |
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958.
FWIW, I actually hit the very same test flakiness today, thus adding more info to Job representation will indeed be helpful for investigation.
PR checklist: