chore: copy all samples into samples/snippets #203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
busunkim96
changed the title
busunkim96
force-pushed
the
move-samples
branch
from
4cfd63e to
6f3f1f9
Compare
tseaver
suggested changes
Aug 4, 2020
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
Deleting tests/__init__.py breaks Python 2.7 unit tests.
| session.run("py.test", os.path.join("docs", "snippets.py"), *session.posargs) | ||
| session.run("py.test", "samples", "--ignore=samples/snippets", *session.posargs) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
We need to drop the linting of docs/samples below (Github isn't letting me leave the comment there).
Contributor
|
Are we planning on continuing this PR? I notice that we just added a separate Kokoro config for the "snippets". |
1 task
Contributor
|
I feel like if this task still needs to be done, it might be more efficient to make a new PR — @tswast and @busunkim96 what do you think? cc: @leahecole and @steffnay for context. |
Contributor
|
Yes, we start fresh. I think we can consider this task to be part of #366. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: