Skip to content

chore: delete duplicate code from snippets.py #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 2 commits into from
Jan 10, 2023
Merged

chore: delete duplicate code from snippets.py #1458

tswast merged 2 commits into from
Jan 10, 2023

Conversation

@Mattix23
Copy link
Contributor

@Mattix23 Mattix23 commented Jan 10, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@Mattix23 Mattix23 requested a review from a team January 10, 2023 16:48
@Mattix23 Mattix23 requested review from a team as code owners January 10, 2023 16:48
@Mattix23 Mattix23 requested review from dandhlee and prash-mi January 10, 2023 16:48
@snippet-bot
Copy link

snippet-bot bot commented Jan 10, 2023 •
edited
Loading

You are about to delete the following frozen region tag.

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 10, 2023
@Mattix23 Mattix23 force-pushed the snippets_delete-mtorresjr branch from 03aedb3 to 3178add Compare January 10, 2023 16:56
@tswast
Copy link
Contributor

tswast commented Jan 10, 2023 

Traceback (most recent call last):
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/cmd/build.py", line 280, in build_main
    app.build(args.force_all, filenames)
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/application.py", line 350, in build
    self.builder.build_update()
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 292, in build_update
    self.build(to_build,
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 306, in build
    updated_docnames = set(self.read())
  File "/usr/local/lib/python3.8/contextlib.py", line 120, in __exit__
    next(self.gen)
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 213, in pending_warnings
    memhandler.flushTo(logger)
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 178, in flushTo
    logger.handle(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 950, in handle
    rv = self.filter(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 811, in filter
    result = f.filter(record)
  File "/tmpfs/src/github/python-bigquery/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 423, in filter
    raise exc
sphinx.errors.SphinxWarning: /tmpfs/src/github/python-bigquery/docs/usage/encryption.rst:13:start-after pattern not found: [START bigquery_create_table_cmek]

Warning, treated as error:
/tmpfs/src/github/python-bigquery/docs/usage/encryption.rst:13:start-after pattern not found: [START bigquery_create_table_cmek]
nox > Command sphinx-build -W -T -N -b html -d [docs/_build/doctrees/](http://docs/_build/doctrees/) [docs/](http://docs/) [docs/_build/html/](http://docs/_build/html/) failed with exit code 2
nox > Session docs failed.

@tswast tswast enabled auto-merge (squash) January 10, 2023 17:35
@tswast tswast merged commit e885f3c into main Jan 10, 2023
@tswast tswast deleted the snippets_delete-mtorresjr branch January 10, 2023 18:03
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @abdelmegahedgoogle
chore: delete duplicate code from snippets.py (googleapis#1458)
cfc97d2 
* chore: delete duplicate code samples from snippets.py

* fixed reference to code sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@prash-mi prash-mi Awaiting requested review from prash-mi

@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee was automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mattix23 @tswast