Skip to content

chore: install all sample dependencies when type checking samples #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 2 commits into from
Jan 6, 2023
Merged

chore: install all sample dependencies when type checking samples #1455

tswast merged 2 commits into from
Jan 6, 2023

Conversation

@thejaredchapman
Copy link
Contributor

@thejaredchapman thejaredchapman commented Jan 6, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1453: 🦕

@thejaredchapman thejaredchapman requested a review from a team January 6, 2023 17:40
@thejaredchapman thejaredchapman requested review from a team as code owners January 6, 2023 17:40
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 6, 2023
@tswast tswast enabled auto-merge (squash) January 6, 2023 17:41
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2023
@tswast tswast merged commit ed1de4f into main Jan 6, 2023
@tswast tswast deleted the issue1453-mypy_samples branch January 6, 2023 18:09
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@thejaredchapman @abdelmegahedgoogle
chore: install all sample dependencies when type checking samples (go…
06856db 
…ogleapis#1455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

@kurtisvg kurtisvg Awaiting requested review from kurtisvg kurtisvg is a code owner automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kokoro failing due to mypy_samples

2 participants

@thejaredchapman @tswast