Skip to content

deps: remove upper bound on packaging dependency #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 6 commits into from
Jan 13, 2023
Merged

deps: remove upper bound on packaging dependency #1440

tswast merged 6 commits into from
Jan 13, 2023

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 13, 2022 •
edited
Loading

Towards #1435

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #1435
Fixes #1400
🦕

@tswast tswast requested a review from a team December 13, 2022 22:38
@tswast tswast requested a review from a team as a code owner December 13, 2022 22:38
@tswast tswast requested a review from Neenu1995 December 13, 2022 22:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 13, 2022
chalmerlowe
chalmerlowe approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2022
@tswast
Copy link
Contributor Author

tswast commented Dec 19, 2022

TODO: Need to investigate unit test failure:

______ TestPyarrowVersions.test_installed_version_returns_parsed_version _______

self = <tests.unit.test__helpers.TestPyarrowVersions testMethod=test_installed_version_returns_parsed_version>

    def test_installed_version_returns_parsed_version(self):
        versions = self._object_under_test()

        with mock.patch("pyarrow.__version__", new="1.2.3"):
            version = versions.installed_version

>       assert version.major == 1
E       AttributeError: 'Version' object has no attribute 'major'

hirosassa
hirosassa reviewed Jan 4, 2023
View reviewed changes
Copy link

@hirosassa hirosassa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I'm also struggling this problem.

I added a small comment.

testing/constraints-3.7.txt Outdated
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
packaging==14.3
Copy link

@hirosassa hirosassa Jan 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast It looks that the problem you suggest comes from this version constraint.

v14.3 of packaging has no major attribute:
https://github.com/pypa/packaging/blob/14.3/packaging/version.py#L268-L280

I think we need to update the lower bound, too.

Copy link

@hirosassa hirosassa Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major is added since v20.0.

ref: https://github.com/pypa/packaging/releases/tag/20.0

@parthea parthea mentioned this pull request Jan 12, 2023
Merged
1 task
@parthea
Copy link
Contributor

parthea commented Jan 12, 2023

@tswast See related issue #1400

@tswast tswast enabled auto-merge (squash) January 13, 2023 17:15
@tswast tswast merged commit 6088129 into main Jan 13, 2023
@tswast tswast deleted the issue1435-remove-packaging-upper-bound branch January 13, 2023 17:41
@release-please release-please bot mentioned this pull request Jan 13, 2023
Merged
This was referenced Jan 19, 2023
Merged
Closed
This was referenced Jan 24, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@tswast @parthea @abdelmegahedgoogle
deps: remove upper bound on packaging dependency (googleapis#1440)
8f92ef7 
* deps: remove upper bound on packaging dependency

Towards googleapis#1435

* install prerelease version of packaging

* bump minimum packaging version

Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

+1 more reviewer

@hirosassa hirosassa hirosassa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tswast tswast

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require packaging>=20.0

5 participants

@tswast @parthea @hirosassa @chalmerlowe @yoshi-kokoro