Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Nov 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1006 🦕

@tswast tswast requested a review from a team November 3, 2021 21:49
@tswast tswast requested a review from a team as a code owner November 3, 2021 21:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 3, 2021
@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2021

snippets-3.10 should run as a presubmit once internal CL 407388245 is merged

@tswast
Copy link
Contributor Author

tswast commented Nov 3, 2021

Tests pass locally

(dev-3.9) ➜  python-bigquery git:(issue1006-python310) nox -s snippets-3.10 -r
nox > Running session snippets-3.10
nox > Re-using existing virtual environment at .nox/snippets-3-10.
nox > python -m pip install mock pytest google-cloud-testutils -c /Users/swast/src/github.com/googleapis/python-bigquery/testing/constraints-3.10.txt
nox > python -m pip install google-cloud-storage -c /Users/swast/src/github.com/googleapis/python-bigquery/testing/constraints-3.10.txt
nox > python -m pip install grpcio -c /Users/swast/src/github.com/googleapis/python-bigquery/testing/constraints-3.10.txt
nox > python -m pip install -e .[bqstorage,pandas,tqdm,opentelemetry] -c /Users/swast/src/github.com/googleapis/python-bigquery/testing/constraints-3.10.txt
nox > py.test docs/snippets.py
=============================== test session starts ===============================
platform darwin -- Python 3.10.0, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /Users/swast/src/github.com/googleapis/python-bigquery
collected 20 items                                                                

docs/snippets.py ....sssss...........                                       [100%]

================================ warnings summary =================================
.nox/snippets-3-10/lib/python3.10/site-packages/google/cloud/bigquery_storage_v1/services/big_query_read/client.py:17
  /Users/swast/src/github.com/googleapis/python-bigquery/.nox/snippets-3-10/lib/python3.10/site-packages/google/cloud/bigquery_storage_v1/services/big_query_read/client.py:17: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
    from distutils import util

-- Docs: https://docs.pytest.org/en/stable/warnings.html
==================== 15 passed, 5 skipped, 1 warning in 45.76s ====================
nox > py.test samples --ignore=samples/magics --ignore=samples/geography --ignore=samples/snippets
=============================== test session starts ===============================
platform darwin -- Python 3.10.0, pytest-6.2.5, py-1.10.0, pluggy-1.0.0
rootdir: /Users/swast/src/github.com/googleapis/python-bigquery
collected 77 items                                                                

samples/tests/test_add_empty_column.py .                                    [  1%]
samples/tests/test_browse_table_data.py .                                   [  2%]
samples/tests/test_client_list_jobs.py .                                    [  3%]
samples/tests/test_client_load_partitioned_table.py .                       [  5%]
samples/tests/test_client_query.py .                                        [  6%]
samples/tests/test_client_query_add_column.py .                             [  7%]
samples/tests/test_client_query_batch.py .                                  [  9%]
samples/tests/test_client_query_destination_table.py .                      [ 10%]
samples/tests/test_client_query_destination_table_clustered.py .            [ 11%]
samples/tests/test_client_query_destination_table_cmek.py .                 [ 12%]
samples/tests/test_client_query_destination_table_legacy.py .               [ 14%]
samples/tests/test_client_query_dry_run.py .                                [ 15%]
samples/tests/test_client_query_legacy_sql.py .                             [ 16%]
samples/tests/test_client_query_relax_column.py .                           [ 18%]
samples/tests/test_client_query_w_array_params.py .                         [ 19%]
samples/tests/test_client_query_w_named_params.py .                         [ 20%]
samples/tests/test_client_query_w_positional_params.py .                    [ 22%]
samples/tests/test_client_query_w_struct_params.py .                        [ 23%]
samples/tests/test_client_query_w_timestamp_params.py .                     [ 24%]
samples/tests/test_copy_table.py .                                          [ 25%]
samples/tests/test_copy_table_cmek.py .                                     [ 27%]
samples/tests/test_copy_table_multiple_source.py .                          [ 28%]
samples/tests/test_create_dataset.py .                                      [ 29%]
samples/tests/test_create_job.py .                                          [ 31%]
samples/tests/test_create_table.py .                                        [ 32%]
samples/tests/test_create_table_clustered.py .                              [ 33%]
samples/tests/test_create_table_range_partitioned.py .                      [ 35%]
samples/tests/test_dataset_exists.py .                                      [ 36%]
samples/tests/test_dataset_label_samples.py .                               [ 37%]
samples/tests/test_delete_dataset.py .                                      [ 38%]
samples/tests/test_delete_table.py .                                        [ 40%]
samples/tests/test_download_public_data.py .                                [ 41%]
samples/tests/test_download_public_data_sandbox.py .                        [ 42%]
samples/tests/test_get_dataset.py .                                         [ 44%]
samples/tests/test_get_table.py .                                           [ 45%]
samples/tests/test_list_datasets.py .                                       [ 46%]
samples/tests/test_list_datasets_by_label.py .                              [ 48%]
samples/tests/test_list_tables.py .                                         [ 49%]
samples/tests/test_load_table_clustered.py .                                [ 50%]
samples/tests/test_load_table_dataframe.py .                                [ 51%]
samples/tests/test_load_table_file.py .                                     [ 53%]
samples/tests/test_load_table_uri_autodetect_csv.py .                       [ 54%]
samples/tests/test_load_table_uri_autodetect_json.py .                      [ 55%]
samples/tests/test_load_table_uri_avro.py .                                 [ 57%]
samples/tests/test_load_table_uri_cmek.py .                                 [ 58%]
samples/tests/test_load_table_uri_csv.py .                                  [ 59%]
samples/tests/test_load_table_uri_json.py .                                 [ 61%]
samples/tests/test_load_table_uri_orc.py .                                  [ 62%]
samples/tests/test_load_table_uri_parquet.py .                              [ 63%]
samples/tests/test_load_table_uri_truncate_avro.py .                        [ 64%]
samples/tests/test_load_table_uri_truncate_csv.py .                         [ 66%]
samples/tests/test_load_table_uri_truncate_json.py .                        [ 67%]
samples/tests/test_load_table_uri_truncate_orc.py .                         [ 68%]
samples/tests/test_load_table_uri_truncate_parquet.py .                     [ 70%]
samples/tests/test_model_samples.py .                                       [ 71%]
samples/tests/test_query_external_gcs_temporary_table.py .                  [ 72%]
samples/tests/test_query_external_sheets_permanent_table.py .               [ 74%]
samples/tests/test_query_external_sheets_temporary_table.py .               [ 75%]
samples/tests/test_query_no_cache.py .                                      [ 76%]
samples/tests/test_query_pagination.py .                                    [ 77%]
samples/tests/test_query_script.py .                                        [ 79%]
samples/tests/test_query_to_arrow.py .                                      [ 80%]
samples/tests/test_routine_samples.py ......                                [ 88%]
samples/tests/test_table_exists.py .                                        [ 89%]
samples/tests/test_table_insert_rows.py .                                   [ 90%]
samples/tests/test_table_insert_rows_explicit_none_insert_ids.py .          [ 92%]
samples/tests/test_undelete_table.py .                                      [ 93%]
samples/tests/test_update_dataset_access.py .                               [ 94%]
samples/tests/test_update_dataset_default_partition_expiration.py .         [ 96%]
samples/tests/test_update_dataset_default_table_expiration.py .             [ 97%]
samples/tests/test_update_dataset_description.py .                          [ 98%]
samples/tests/test_update_table_require_partition_filter.py .               [100%]

================================ warnings summary =================================
.nox/snippets-3-10/lib/python3.10/site-packages/google/cloud/bigquery_storage_v1/services/big_query_read/client.py:17
  /Users/swast/src/github.com/googleapis/python-bigquery/.nox/snippets-3-10/lib/python3.10/site-packages/google/cloud/bigquery_storage_v1/services/big_query_read/client.py:17: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
    from distutils import util

-- Docs: https://docs.pytest.org/en/stable/warnings.html
==================== 77 passed, 1 warning in 354.29s (0:05:54) ====================
nox > Session snippets-3.10 was successful.

@tseaver tseaver merged commit c3dbeeb into main Nov 4, 2021
@tseaver tseaver deleted the issue1006-python310 branch November 4, 2021 13:16
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.10 support

2 participants