This repository was archived by the owner on Feb 28, 2024. It is now read-only.
build: use trampoline_v2 for python samples#308
Closed
busunkim96 wants to merge 5 commits intomainfrom
Closed
Conversation
busunkim96
added
the
do not merge
product-auto-label
Bot
added
api: cloudasset
google-cla
Bot
added
the
cla: yes
busunkim96
changed the title
Contributor
|
@busunkim96 How do we keep owlbot from undoing these changes in a future PR? |
busunkim96
added a commit
to googleapis/synthtool
that referenced
this pull request
Oct 5, 2021
…le (#1232) * Use trampoline_v2 ([Docker CI Helper](https://github.com/GoogleCloudPlatform/docker-ci-helper)) for all python samples. * Optionally allow samples to run with a Dockerfile specified in the library repository at `.kokoro/docker/samples`. On a successful test run, this Dockerfile is uploaded to `gcr.io/cloud-devrel-kokoro-resources/{repo-name}-samples-docker`. The option is enabled by passing `custom_samples_dockerfile=True` to `common.py_library` in `owlbot.py`. ```py templated_files = common.py_library(microgenerator=True, custom_samples_dockerfile=True) ``` See googleapis/python-asset#308 for an example of moving samples to to trampoline_v2. See googleapis/python-recaptcha-enterprise#128 for an example of moving to trampoline_v2 + using a custom Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For googleapis/synthtool#1232.