Skip to content

Flake8 linting is incompatible with the black formatting #1087

@Ark-kun

Description

@Ark-kun

Black formats

machine_spec = {
    "machine_type": "n1-standard-2",
}

to

"machine_spec = {"machine_type": "n1-standard-2",}

But Flake8 fails with error:

nox > python -m pip install flake8 black==19.10b0
nox > black --check docs google tests noxfile.py setup.py
All done! ✨ 🍰 ✨
669 files would be left unchanged.
nox > flake8 google tests
tests/system/aiplatform/test_project_id_inference.py:41:65: E231 missing whitespace after ','
nox > Command flake8 google tests failed with exit code 1
nox > Session lint failed.

See the log: https://source.cloud.google.com/results/invocations/4fc606fe-ddd0-4edc-ad78-66c695279171/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-aiplatform%2Fpresubmit%2Fpresubmit/log

Metadata

Metadata

Assignees

Labels

aiplatformIssues related to the AI Platform (Unified) API.api: aiplatformIssues related to the AI Platform API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions