Skip to content

Commit 10e76da

Browse files
matthew29tangcopybara-github
authored andcommitted
chore: Add protobuf 7.x support
Fixes #7132 PiperOrigin-RevId: 1000347632
1 parent 46ae3d0 commit 10e76da

7 files changed

Lines changed: 17 additions & 56 deletions

File tree

‎google/cloud/aiplatform/_streaming_prediction.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ def value_to_tensor(value: Any) -> aiplatform_types.Tensor:
3838
"""
3939
if value is None:
4040
return aiplatform_types.Tensor()
41+
elif isinstance(value, bool):
42+
return aiplatform_types.Tensor(bool_val=[value])
4143
elif isinstance(value, int):
4244
return aiplatform_types.Tensor(int_val=[value])
4345
elif isinstance(value, float):
4446
return aiplatform_types.Tensor(float_val=[value])
45-
elif isinstance(value, bool):
46-
return aiplatform_types.Tensor(bool_val=[value])
4747
elif isinstance(value, str):
4848
return aiplatform_types.Tensor(string_val=[value])
4949
elif isinstance(value, bytes):

‎setup.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@
322322
"google-auth >= 2.47.0, <3.0.0",
323323
"certifi >= 2023.7.22",
324324
"proto-plus >= 1.22.3, <2.0.0",
325-
"protobuf>=3.20.2,<7.0.0,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
325+
"protobuf>=3.20.2,<8.0.0,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
326326
"packaging >= 14.3",
327327
"google-cloud-storage >= 1.32.0, < 4.0.0; python_version<'3.13'",
328328
"google-cloud-storage >= 3.10.0, < 4.0.0; python_version>='3.13'",

‎testing/constraints-3.14.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# -*- coding: utf-8 -*-
22
# This constraints file is required for unit tests.
33
# List all library dependencies and extras in this file.
4-
google-api-core==2.27.0
54
google-auth==2.49.0
65
proto-plus
76
mock==4.0.2
@@ -13,4 +12,5 @@ ipython==8.22.2 # Pinned to unbreak TypeAliasType import error
1312
google-adk==0.0.2
1413
google-genai>=1.10.0
1514
google-vizier==0.1.21
16-
pyarrow>=22.0.0
15+
pyarrow>=22.0.0
16+
protobuf>=7

‎testing/constraints-3.8.txt‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎testing/constraints-3.9.txt‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎testing/constraints-adk.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
protobuf<5.0.0

‎tests/unit/aiplatform/test_initializer.py‎

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -385,12 +385,9 @@ def test_create_client_user_agent(self):
385385
client_class=utils.ModelClientWithOverride
386386
)
387387

388-
for wrapped_method in client._transport._wrapped_methods.values():
389-
# wrapped_method._metadata looks like:
390-
# [('x-goog-api-client', 'model-builder/0.3.1 gl-python/3.7.6 grpc/1.30.0 gax/1.22.2 gapic/0.3.1')]
391-
user_agent = wrapped_method._metadata[0][1]
392-
assert "model-builder/" in user_agent
393-
assert "google.cloud.aiplatform" in user_agent
388+
user_agent = client._client_info.to_user_agent()
389+
assert "model-builder/" in user_agent
390+
assert "google.cloud.aiplatform" in user_agent
394391

395392
def test_create_client_user_agent_top_level_method(self):
396393
initializer.global_config.init(project=_TEST_PROJECT, location=_TEST_LOCATION)
@@ -404,14 +401,11 @@ def __init__(self):
404401
client_class=utils.ModelClientWithOverride
405402
)
406403

407-
for wrapped_method in SomeClass()._client._transport._wrapped_methods.values():
408-
# wrapped_method._metadata looks like:
409-
# [('x-goog-api-client', 'model-builder/0.3.1 gl-python/3.7.6 grpc/1.30.0 gax/1.22.2 gapic/0.3.1')]
410-
user_agent = wrapped_method._metadata[0][1]
411-
assert (
412-
f"+{initializer._TOP_GOOGLE_CONSTRUCTOR_METHOD_TAG}+vertexai.SomeClass.__init__"
413-
in user_agent
414-
)
404+
user_agent = SomeClass()._client._client_info.to_user_agent()
405+
assert (
406+
f"+{initializer._TOP_GOOGLE_CONSTRUCTOR_METHOD_TAG}+vertexai.SomeClass.__init__"
407+
in user_agent
408+
)
415409

416410
def test_create_client_appended_user_agent(self):
417411
appended_user_agent = ["fake_user_agent", "another_fake_user_agent"]
@@ -421,12 +415,9 @@ def test_create_client_appended_user_agent(self):
421415
appended_user_agent=appended_user_agent,
422416
)
423417

424-
for wrapped_method in client._transport._wrapped_methods.values():
425-
# wrapped_method._metadata looks like:
426-
# [('x-goog-api-client', 'model-builder/0.3.1 gl-python/3.7.6 grpc/1.30.0 gax/1.22.2 gapic/0.3.1')]
427-
user_agent = wrapped_method._metadata[0][1]
428-
assert " " + appended_user_agent[0] in user_agent
429-
assert " " + appended_user_agent[1] in user_agent
418+
user_agent = client._client_info.to_user_agent()
419+
assert " " + appended_user_agent[0] in user_agent
420+
assert " " + appended_user_agent[1] in user_agent
430421

431422
def test_set_api_endpoint(self):
432423
initializer.global_config.init(

0 commit comments

Comments
 (0)