This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Conversation
sofisl
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node#4743.
We support
Longtype (which is theprotobufjsrepresentation ofint64anduint64), but one very special case, where the proto contains eitherrepeated int64ormap<..., int64>, does not work properly. Fixing that.An unrelated change is to add
protobufjs-clitodevDependencies; it's now needed for runningnpm run compile-test-protosto regenerate the fixtures. It was not needed before sincepbjswas originally a part ofprotobufjs, but now it lives in a separate package.On a personal note, I'm quite happy that my last code change while working for Google is for this library, which I created and published about 3 years ago, and enjoyed working on :)