Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 27, 2021

@tseaver tseaver requested a review from software-dov October 27, 2021 16:26
@tseaver tseaver requested a review from a team as a code owner October 27, 2021 16:26
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
@software-dov
Copy link
Contributor

QQ: why do we need these constraints files? Doesn't the minimum version in setup.py give us the assurance that the minimum version installed is the one we care about?

@tseaver
Copy link
Contributor Author

tseaver commented Oct 27, 2021

@software-dov

QQ: why do we need these constraints files? Doesn't the minimum version in setup.py give us the assurance that the minimum version installed is the one we care about?

We need to continue to test that our software runs with the minimum version specified in setup.py. Otherwise, as new versions of a dependency are released, our code might come to depend (unknowingly) on new features / behavior of that release, and would then break in environments where our specified minimum was installed. Our convention is to test those specified minimum versions on the "oldest" Python version we support.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 27, 2021

E.g. if you had pushed #270 without updating setup.py, the unit-3.6 tests would have failed due to the constraint.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #273 (eb99b25) into master (6a43682) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #273    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           20        22     +2     
  Lines          862       963   +101     
  Branches       149       171    +22     
==========================================
+ Hits           862       963   +101     
Impacted Files Coverage Δ
proto/modules.py 100.00% <ø> (ø)
proto/enums.py 100.00% <100.00%> (ø)
proto/fields.py 100.00% <100.00%> (ø)
proto/marshal/collections/repeated.py 100.00% <100.00%> (ø)
proto/marshal/marshal.py 100.00% <100.00%> (ø)
proto/marshal/rules/bytes.py 100.00% <100.00%> (ø)
proto/marshal/rules/message.py 100.00% <100.00%> (ø)
proto/marshal/rules/stringy_numbers.py 100.00% <100.00%> (ø)
proto/message.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35b77e...eb99b25. Read the comment docs.

@tseaver tseaver merged commit 8e914a7 into master Oct 27, 2021
@tseaver tseaver deleted the 270-test-minimum-protobuf-version branch October 27, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants