This repository was archived by the owner on Feb 23, 2026. It is now read-only.
refactor: prefer super().__setattr__ over __dict__ manipulation#174
Merged
software-dov merged 1 commit intogoogleapis:masterfrom Jan 5, 2021
software-dov:super
Merged
refactor: prefer super().__setattr__ over __dict__ manipulation#174software-dov merged 1 commit intogoogleapis:masterfrom software-dov:super
software-dov merged 1 commit intogoogleapis:masterfrom
software-dov:super
Conversation
software-dov
requested review from
a team,
arithmetic1728,
busunkim96 and
vchudnov-g
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 862 862
Branches 149 149
=========================================
Hits 862 862
Continue to review full report at Codecov.
|
vchudnov-g
approved these changes
Jan 5, 2021
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
lgtm (though I confess to not knowing the ins and outs of this Py construct)
I suggest adding a brief description of the motivation for this change to the PR description.
software-dov
added
the
automerge
busunkim96
approved these changes
Jan 5, 2021
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
super().__setattr__is a preferred idiom over directly manipulating an object's__dict__. This allows for a more seamless transition to a named tuple subclass, or__slots__.