This repository was archived by the owner on Feb 23, 2026. It is now read-only.
test: unknown fields are preserved#160
Merged
software-dov merged 2 commits intogoogleapis:masterfrom Nov 3, 2020
software-dov:unknown-fields
Merged
test: unknown fields are preserved#160software-dov merged 2 commits intogoogleapis:masterfrom software-dov:unknown-fields
software-dov merged 2 commits intogoogleapis:masterfrom
software-dov:unknown-fields
Conversation
Consider the following:
```proto
message Old {
string name = 1;
}
message New {
string name = 1;
string path = 2;
}
```
We can think of `New` as being a minor version release update of `Old`.
If a client using the older version receives a message over the wire
from a server using the newer version, it is desirable that any new,
unknown fields are preserved. These can store context the server
needs, which is important in get/modify/set loops.
software-dov
requested review from
a team,
arithmetic1728,
busunkim96,
crwilcox,
lukesneeringer,
vchudnov-g and
xiaozhenliu-gg5
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 863 862 -1
Branches 149 149
=========================================
- Hits 863 862 -1
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Nov 3, 2020
busunkim96
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following:
We can think of
Newas being a minor version release update ofOld.If a client using the older version receives a message over the wire
from a server using the newer version, it is desirable that any new,
unknown fields are preserved. These can store context the server
needs, which is important in get/modify/set loops.