Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

py3 fix for AppAssertionCredentials on GCE#152

Closed
ptone wants to merge 1 commit intogoogleapis:masterfrom
ptone:gce-py3
Closed

py3 fix for AppAssertionCredentials on GCE#152
ptone wants to merge 1 commit intogoogleapis:masterfrom
ptone:gce-py3

Conversation

@ptone
Copy link
Copy Markdown

@ptone ptone commented Mar 28, 2015

fixes #150

@googlebot
Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@ptone
Copy link
Copy Markdown
Author

ptone commented Mar 28, 2015

Turns out this took a very minor change to fix

For the CLA - how do I associate my github name with the corp CLA (devsite tool has me as covered under that)?

[email protected]

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 64.8% when pulling fc23a7f on ptone:gce-py3 into 26adb9a on google:master.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 64.8% when pulling cc8dae3 on ptone:gce-py3 into 26adb9a on google:master.

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

What hope is there for test coverage for this? What about the fact that tests for the current draft are failing?

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Aug 14, 2015

Closing this since #272 covers it and is active

@dhermes dhermes closed this Aug 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue with AppAssertionCredentials and Python3

5 participants