Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

docs: improve detect.js samples#300

Merged
JustinBeckwith merged 9 commits intomasterfrom
nnegrey-patch-1
Jan 2, 2019
Merged

docs: improve detect.js samples#300
JustinBeckwith merged 9 commits intomasterfrom
nnegrey-patch-1

Conversation

@nnegrey
Copy link
Copy Markdown
Contributor

@nnegrey nnegrey commented Dec 27, 2018

The destination should be a GCS bucket folder, not a filename as the results concatenate a naming system if the file is multiple pages long.

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

The destination should be a GCS bucket folder, not a filename as the results concatenate a naming system if the file is multiple pages long.
@nnegrey nnegrey requested a review from happyhuman December 27, 2018 17:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 27, 2018
Comment thread samples/detect.js Outdated
@JustinBeckwith JustinBeckwith changed the title Update detect.js docs: improve detect.js samples Jan 2, 2019
@JustinBeckwith JustinBeckwith merged commit c5354fb into master Jan 2, 2019
@nnegrey nnegrey deleted the nnegrey-patch-1 branch January 2, 2019 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants