This repository was archived by the owner on Jul 20, 2023. It is now read-only.
chore: modernize the samples and sample tests#297
Merged
jkwlui merged 1 commit intogoogleapis:masterfrom Dec 18, 2018
JustinBeckwith:chai
Merged
chore: modernize the samples and sample tests#297jkwlui merged 1 commit intogoogleapis:masterfrom JustinBeckwith:chai
jkwlui merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:chai
Conversation
Contributor
|
I'm curious as to why |
jkwlui
approved these changes
Dec 18, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So you ever have one of those PRs you start where it begins small, then slowly grows out of control? Yeah, this is one of those. Sorry about that. This does a few things:
@google-cloud/nodejs-repo-toolsfor execaasync,sinon, andproxyquiremodules.assert.matchassertion fromchaifor better failure assertionstextDetectionsample to use modern es6 syntax (promises, classes, etc)automlsample test, which before this didn't run at all