Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

chore: modernize the samples and sample tests#297

Merged
jkwlui merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:chai
Dec 18, 2018
Merged

chore: modernize the samples and sample tests#297
jkwlui merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:chai

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Dec 18, 2018

So you ever have one of those PRs you start where it begins small, then slowly grows out of control? Yeah, this is one of those. Sorry about that. This does a few things:

  • Swaps @google-cloud/nodejs-repo-tools for execa
  • Drops usage of the async, sinon, and proxyquire modules.
  • Uses the assert.match assertion from chai for better failure assertions
  • Rewrites the textDetection sample to use modern es6 syntax (promises, classes, etc)
  • Flattens out the sample tests so they all live in one directory
  • Fixes a failing test on master where I can only assume the output from the API changed
  • Skips the failing automl sample test, which before this didn't run at all

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Dec 18, 2018

I'm curious as to why automl sample tests are in this repository.. @nirupa-kumar

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants