docs(samples): updated samples code to use async/await and tests to use mocha by vijay-qlogic · Pull Request #241 · googleapis/nodejs-vision

vijay-qlogic · 2018-10-24T18:00:38Z

Fixes googleapis/google-cloud-node/issues/2869 (it's a good idea to open an issue first for discussion)

Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

codecov · 2018-10-25T14:17:11Z

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #241   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718116d...1d76f10. Read the comment docs.

Sign in to view

-    .catch(err => {
-      console.error('ERROR:', err);
-    });
+  const [{faceAnnotations: faces}] = await client.faceDetection(fileName);


Sign in to view

+  });
+  pngStream.on('error', console.log);
+  pngStream.on('end', () => {
+    return;


Sign in to view

 // Run the example
 // [START vision_face_detection_tutorial_run_application]
-function main(inputFile, outputFile, Canvas, callback) {
+async function main(inputFile, outputFile, Canvas, callback) {


Sign in to view

-  .catch(err => {
-    console.error('ERROR:', err);
-  });
+(async () => {


Sign in to view

+async function lookup(words) {
  const index = new Index();
-  index.lookup(words, function(err, hits) {
+  try {


vijay-qlogic · 2018-10-25T18:45:40Z

@JustinBeckwith 'll add fix for samples/faceDetection.js shortly. I may need to change tests as well here.

Sign in to view

-function main(inputDir, callback) {
-  const index = new Index();
+function main(inputDir) {
+  return new Promise((resolve, reject) => {


JustinBeckwith · 2018-10-28T22:00:20Z

@vijay-qlogic as soon as the samples-tests are passing we can merge this :)

JustinBeckwith · 2018-10-30T15:47:35Z

Just a reminder/ping to address the failing sample tests

vijay-qlogic · 2018-10-30T16:45:19Z

Yes, I'm looking into it.. Facing some challenges to resolve the issues here.

JustinBeckwith · 2018-10-30T17:05:07Z

Anything I can do to help? Can you run the sample tests locally on your own?

vijay-qlogic · 2018-10-30T17:13:17Z

With ava, tests run successfully, but asks for redis-server with mocha...
And when I start redis server-locally, it works form me

JustinBeckwith · 2018-11-17T00:01:48Z

It looks like the sample tests are still failing:

 1) quickstart
       should detect labels in a remote file:
     Uncaught Error: ENOENT: no such file or directory, open '/tmpfs/src/github/nodejs-vision/vision/out.png'
(node:127) UnhandledPromiseRejectionWarning: TypeError: Cannot set property 'state' of undefined
    at /tmpfs/src/github/nodejs-vision/samples/node_modules/mocha/lib/runner.js:602:20
    at done (/tmpfs/src/github/nodejs-vision/samples/node_modules/mocha/lib/runnable.js:319:5)
    at /tmpfs/src/github/nodejs-vision/samples/node_modules/mocha/lib/runnable.js:377:11
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
(node:127) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:127) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Finished!
npm ERR! Test failed.  See above for more details.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/[email protected] samples-test: `cd samples/ && npm link ../ && npm test && cd ../`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @google-cloud/[email protected] samples-test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/node/.npm/_logs/2018-11-16T23_30_40_897Z-debug.log
+ cleanup
+ chmod +x /tmpfs/src/gfile/trampoline_cleanup.sh
+ /tmpfs/src/gfile/trampoline_cleanup.sh
+ echo cleanup
cleanup

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2018

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2018

vijay-qlogic force-pushed the asyncify-samples branch from b3f101c to c34c822 Compare October 25, 2018 14:17

JustinBeckwith suggested changes Oct 25, 2018

View reviewed changes

vijay-qlogic force-pushed the asyncify-samples branch from de7dba8 to d0a0001 Compare October 25, 2018 18:47

JustinBeckwith reviewed Oct 28, 2018

View reviewed changes

JustinBeckwith approved these changes Oct 28, 2018

View reviewed changes

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018

vijay-qlogic force-pushed the asyncify-samples branch from e9fda27 to 891052c Compare October 28, 2018 17:33

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2018

vijay-qlogic changed the title ~~docs(samples): updated samples code to use async await~~ docs(samples): updated samples code to use async/await and tests to use mocha Oct 29, 2018

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018

kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 2, 2018

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2018

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2018

vijay-qlogic force-pushed the asyncify-samples branch 2 times, most recently from f9f67ca to be0e660 Compare November 8, 2018 17:47

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018

vijay-qlogic force-pushed the asyncify-samples branch from 687f865 to 9ea91ca Compare November 15, 2018 13:52

sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018

JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 17, 2018

vijay-qlogic added 6 commits November 18, 2018 18:39

updated samples code to use async await

6ba3bcc

added code review updates

aee3e5a

converted samples test from ava to mocha

d1cec40

updates samples code to use async await for productSearch

a823282

update automl samples to use async/await and mocha instead of ava

5ffa0a8

Added fix for test failuers

1d76f10

vijay-qlogic force-pushed the asyncify-samples branch from e9cd363 to 1d76f10 Compare November 18, 2018 13:10

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2018

JustinBeckwith merged commit af55904 into googleapis:master Nov 18, 2018

snyk-bot mentioned this pull request Mar 4, 2020

[Snyk] Upgrade @google-cloud/vision from 0.21.0 to 0.25.0 habbdt/la-ace-find-seller#1

Open

Conversation

vijay-qlogic commented Oct 24, 2018

Uh oh!

codecov Bot commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

vijay-qlogic commented Oct 25, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

JustinBeckwith commented Oct 28, 2018

Uh oh!

JustinBeckwith commented Oct 30, 2018

Uh oh!

vijay-qlogic commented Oct 30, 2018

Uh oh!

JustinBeckwith commented Oct 30, 2018

Uh oh!

vijay-qlogic commented Oct 30, 2018

Uh oh!

JustinBeckwith commented Nov 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Oct 25, 2018 •

edited

Loading