Param "scoreThreshold" should be "score_threshold"#234
Param "scoreThreshold" should be "score_threshold"#234JustinBeckwith merged 6 commits intogoogleapis:masterfrom
Conversation
Sine 18 Oct 2018, I found that the scoreThreshold param won't work and encounter "Error: 3 INVALID_ARGUMENT: Request contains an invalid argument." during prediction call. I compared the doc below and the params should be score_threshold instead of scoreThreshold. https://cloud.google.com/vision/automl/docs/reference/rest/v1beta1/projects.locations.models/predict#request-body
googlebot
added
the
cla: yes
ghost
assigned
|
@beccasaurus @googleapis/ml-apis would y'all mind taking a look? |
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Ah, I was hesitant to accept this because the Node.js client does not use Also, the REST API endpoint isn't called, here is the API endpoint for the underlying RPC endpoint: Upon taking a closer look, this makes sense. Great catch! CLA ok. Bug confirmed. Updating the branch & merging... |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 83 83
=====================================
Hits 83 83Continue to review full report at Codecov.
|
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
|
Samples test failure seems unrelated. |
6 participants
Sine 18 Oct 2018, I found that the scoreThreshold param won't work and encounter "Error: 3 INVALID_ARGUMENT: Request contains an invalid argument." during prediction call. I compared the doc below and the params should be score_threshold instead of scoreThreshold.
https://cloud.google.com/vision/automl/docs/reference/rest/v1beta1/projects.locations.models/predict#request-body