Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

[DO NOT MERGE] Vision GA – vision_localize_objects & vision_localize_object_gcs#200

Merged
beccasaurus merged 6 commits intogoogleapis:masterfrom
nirupa-kumar:vision-ga
Sep 21, 2018
Merged

[DO NOT MERGE] Vision GA – vision_localize_objects & vision_localize_object_gcs#200
beccasaurus merged 6 commits intogoogleapis:masterfrom
nirupa-kumar:vision-ga

Conversation

@nirupa-kumar
Copy link
Copy Markdown
Contributor

@nirupa-kumar nirupa-kumar commented Sep 18, 2018 •
edited
Loading

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2018
@ghost ghost assigned JustinBeckwith Sep 18, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ee15ac8. Read the comment docs.

@nirupa-kumar nirupa-kumar changed the title Vision-GA - vision_localize_objects & vision_localize_object_gcs [DO_NOT_MERGE]Vision-GA - vision_localize_objects & vision_localize_object_gcs Sep 18, 2018
@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

nirupa-kumar commented Sep 18, 2018

@beccasaurus Please have a look

beccasaurus
beccasaurus suggested changes Sep 18, 2018
View reviewed changes
Comment thread README.md
beccasaurus
beccasaurus reviewed Sep 18, 2018
View reviewed changes
Comment thread samples/detect.js Outdated
beccasaurus
beccasaurus reviewed Sep 18, 2018
View reviewed changes
Comment thread samples/system-test/detect.test.js Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ee15ac8. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ee15ac8. Read the comment docs.

@beccasaurus beccasaurus added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 18, 2018
@beccasaurus beccasaurus changed the title [DO_NOT_MERGE]Vision-GA - vision_localize_objects & vision_localize_object_gcs [DO NOT MERGE] Vision GA – vision_localize_objects & vision_localize_object_gcs Sep 18, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ee15ac8. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ddc3414. Read the comment docs.

2 similar comments
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ddc3414. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ddc3414. Read the comment docs.

@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

nirupa-kumar commented Sep 18, 2018

Fixed issues as per review comments.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb8505...ddc3414. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2018 •
edited
Loading

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #200   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     83           
=====================================
  Hits           83     83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4b9e0...7bdcb43. Read the comment docs.

@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

nirupa-kumar commented Sep 19, 2018

@beccasaurus Please let me know if there is anything else.

@beccasaurus beccasaurus self-requested a review September 20, 2018 05:31
beccasaurus
beccasaurus reviewed Sep 20, 2018
View reviewed changes
Comment thread samples/system-test/detect.test.js Outdated
beccasaurus
beccasaurus suggested changes Sep 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@beccasaurus beccasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change files[8] to files[8].localPath to fix failing test

@ghost ghost assigned beccasaurus Sep 21, 2018
@beccasaurus beccasaurus merged commit 42f70f5 into googleapis:master Sep 21, 2018
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@beccasaurus beccasaurus beccasaurus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beccasaurus beccasaurus

@JustinBeckwith JustinBeckwith

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nirupa-kumar @beccasaurus @JustinBeckwith @googlebot