Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

Product search rebased#196

Merged
beccasaurus merged 27 commits intogoogleapis:masterfrom
nirupa-kumar:product-search-rebased
Sep 18, 2018
Merged

Product search rebased#196
beccasaurus merged 27 commits intogoogleapis:masterfrom
nirupa-kumar:product-search-rebased

Conversation

@nirupa-kumar
Copy link
Copy Markdown
Contributor

Product Search (v1p3beta1)

This Pull Request adds the code samples for cloud.google.com documentation for Product Search How-to Guides

Product Search How-to Guides –> vision/product-search/docs/how-to

products.js

  • create_product
  • get_product
  • list_products
  • delete_product
  • update_product_labels

productSets.js

  • create_product_set
  • get_product_set
  • list_product_sets
  • delete_product_set

–> Products in productSets.js

  • add_product_to_product_set
  • list_products_in_product_set
  • remove_product_from_product_set

referenceImages.js

  • create_reference_image
  • get_reference_image
  • list_reference_images
  • delete_reference_image

similarProducts.js

  • get_similar_products_file
  • get_similar_products_uri

importProductSets.js

  • import_product_images
    This last sample has been newly added after looking into the python and Java samples for comparison.

For the canonical versions, please see the Python Product Search Samples in python-docs-samples

These samples are in Beta and require using the v1p3beta1 API endpoint:

const vision = require('@google-cloud/vision').v1p3beta1;
const client = new vision.ProductSearchClient();

Before being ready for review & merge:

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) - working on this one - README is not getting updated with the Product Search code - looking into it.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2018
@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

nirupa-kumar commented Sep 14, 2018

@beccataylor @JustinBeckwith
Please let me know if this makes more sense. Created a new branch - rebased and including all the Product Search related code. If this seems ok, will go ahead and close the old PR (#192).

Comment thread samples/package.json Outdated
Comment thread samples/package.json Outdated
Comment thread samples/package.json Outdated
@@ -0,0 +1,5 @@
---

This comment was marked as spam.

This comment was marked as spam.

Comment thread smoke-test/image_annotator_smoke_test.js
@becca
Copy link
Copy Markdown

becca commented Sep 14, 2018

@nirupa-kumar @JustinBeckwith 👋 hey there! i think you might have pinged the wrong becca 😊

@nirupa-kumar nirupa-kumar mentioned this pull request Sep 17, 2018
22 tasks
@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

@beccataylor
I have fixed all the issues reported as part of #192
There is one open issue with the Kokoro tests running , please have a look and let me know if there is anything else required.

// Imports the Google Cloud client library
const vision = require('@google-cloud/vision').v1p3beta1;
// Creates a client
var client = new vision.ProductSearchClient();

This comment was marked as spam.

@JustinBeckwith
Copy link
Copy Markdown
Contributor

LGTM w/ nits

@nirupa-kumar
Copy link
Copy Markdown
Contributor Author

@JustinBeckwith
Fixed the nits. Please approve.

@JustinBeckwith
Copy link
Copy Markdown
Contributor

Thanks! There are still many instances of var. Would you mind switching these to let / const?

@beccasaurus beccasaurus merged commit b4cf655 into googleapis:master Sep 18, 2018
@beccasaurus
Copy link
Copy Markdown
Contributor

Aaaaaaaannnnnnndddddd.... MERGED 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants