Product search samples by nirupa-kumar · Pull Request #192 · googleapis/nodejs-vision

nirupa-kumar · 2018-09-11T15:56:47Z

Product Search (v1p3beta1)

This Pull Request adds the code samples for cloud.google.com documentation for Product Search How-to Guides

Product Search How-to Guides –> vision/product-search/docs/how-to

products.js

productSets.js

create_product_set
get_product_set
list_product_sets
delete_product_set

–> Products in productSets.js

add_product_to_product_set
list_products_in_product_set
remove_product_from_product_set

referenceImages.js

create_reference_image
get_reference_image
list_reference_images
delete_reference_image

similarProducts.js

get_similar_products_file
get_similar_products_uri

importProductSets.js

import_product_images
This last sample has been newly added after looking into the python and Java samples for comparison.

For the canonical versions, please see the Python Product Search Samples in python-docs-samples

These samples are in Beta and require using the v1p3beta1 API endpoint:

const vision = require('@google-cloud/vision').v1p3beta1;
const client = new vision.ProductSearchClient();

Before being ready for review & merge:

Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary) - working on this one - README is not getting updated with the Product Search code - looking into it.

…st assertions

…ceImage

…tSet

…s/nodejs-vision into product-search-samples

… search

googlebot · 2018-09-11T15:57:07Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

nirupa-kumar · 2018-09-11T16:00:56Z

@Beccca @ace-n @jmdobry
Please review.
I'm guessing since I do not have write access on the repo I am unable to add to the original pull request (#136) Please let me know if there is anything that can be done.
I have also added one more sample for importing product sets that was previously not included in the list. This matches up with the samples found in Java and python.
The README file generation is currently not working and I am looking into it.

codecov · 2018-09-11T17:40:26Z

Codecov Report

Merging #192 into product-search-samples will not change coverage.
The diff coverage is 100%.

@@                  Coverage Diff                  @@
##           product-search-samples   #192   +/-   ##
=====================================================
  Coverage                     100%   100%           
=====================================================
  Files                           2      2           
  Lines                          83     83           
=====================================================
  Hits                           83     83

Impacted Files	Coverage Δ
src/helpers.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ab090...e1d9a71. Read the comment docs.

googlebot · 2018-09-13T22:15:35Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Sign in to view

      - image: 'node:6'
        user: node
    steps: &unit_tests_steps
-      - checkout


googlebot · 2018-09-13T22:54:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

beccasaurus · 2018-09-14T20:18:38Z

The PR currently shows 58 Commits & 79 Files Changed, only a few of which are related to Product Search samples

I'm not sure what caused this?

The Product Search content itself LGTM as far as I can tell, but the diff is disconcerting 😕

JustinBeckwith · 2018-09-14T20:22:23Z

It looks like this is getting merged into the product-search-samples branch on this repo. Is that branch up to date with master? Why is the PR not against master?

nirupa-kumar · 2018-09-14T20:52:47Z

@becca @JustinBeckwith
Please let me know if you know of a better way to approach this.
In short - there are three people who have worked on this, me included.The branch has not been merged into master. I have updated the branch itself with the master, but when doing a push - the 50+ commits got tagged along. One thing I am trying to do right now is doing a merge with the master and a rebase. But when doing a push (after the rebase), it gets rejected. The solutions I have found online range from "doing a force push" to "deleting the branch in remote and pushing it again". Trying to figure out which one makes more sense.

P.S.: I do not have write access to the repo.

beccasaurus · 2018-09-14T22:29:39Z

Oh! I didn't notice that this PR isn't being sent to master! Let me see if I can change that post-hoc...

beccasaurus · 2018-09-14T22:30:17Z

THERE WE GO! Good catch @JustinBeckwith!

googlebot · 2018-09-14T22:30:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-09-14T22:31:58Z

CLAs look good, thanks!

beccasaurus · 2018-09-14T22:33:09Z

I'll LGTM pending test pass!

nirupa-kumar · 2018-09-17T17:36:18Z

Will be closing this PR , since new one with the rebased code as a direct branch on the master has been created. All review comments here have been resolved as part of #196

Rebecca Taylor and others added 22 commits July 23, 2018 21:30

Update samples to use ^0.21.0 for v1p3beta1

b5233a7

Add Product Search samples to create/list/delete products

5174672

Linting for Product Search create/list/delete

eb0e247

Product Search – Get Product sample

5fe063e

Move Product Search tests into productSearch/

fb48775

Refactor | reuse helper variable in Product Search – List Products te…

191844f

…st assertions

Product Search samples – Product Set create/get/list/delete

9b756b3

updates region tags to standard

98af745

Added sample for createReferenceImage

aa0ca2b

Added getReferenceImage sample (needs fixing)

6348f19

Implemented listReferenceImages, deleteReferenceImage, and getReferen…

c3806ed

…ceImage

Added the sample for addProductToProductSet

e30148e

Added samples for listProductInProductSet and removeProductFromProduc…

395faf0

…tSet

Added inline parameter comments

89e6d78

Added sample for updateProductLabels

b0ab090

Merge branch 'product-search-samples' of https://github.com/googleapi…

27db561

…s/nodejs-vision into product-search-samples

Merge branch 'product-search-samples' of https://github.com/googleapi…

e7ecbab

…s/nodejs-vision into product-search-samples

Updates Product search samples - import product set & similar product…

a9ea92f

… search

Fixing linting issues

21c2d51

Fixing linting issues

b7ea6d2

Fixing linting issues

f90b170

Fixing linting issues

4e8dffd

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 11, 2018

nirupa-kumar added 2 commits September 11, 2018 09:03

Fixing linting issues

83ff365

Fixing linting issues

e1d9a71

beccasaurus self-assigned this Sep 13, 2018

beccasaurus mentioned this pull request Sep 13, 2018

[NOT READY] Samples demonstrating Product Search (v1p3beta1) #136

Closed

21 tasks

beccasaurus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 13, 2018

beccasaurus suggested changes Sep 13, 2018

View reviewed changes

Comment thread .circleci/config.yml

- image: 'node:6'

user: node

steps: &unit_tests_steps

- checkout

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Merging master in product-search-samples

acfa589

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 13, 2018

nirupa-kumar mentioned this pull request Sep 14, 2018

Product search rebased #196

Merged

22 tasks

beccasaurus changed the base branch from product-search-samples to master September 14, 2018 22:29

beccasaurus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 14, 2018

Merge branch 'master' into product-search-samples

eb7d45c

beccasaurus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2018

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2018

beccasaurus approved these changes Sep 14, 2018

View reviewed changes

beccasaurus suggested changes Sep 14, 2018

View reviewed changes

Comment thread samples/productSearch/productSearch.v1p3beta1.js

beccasaurus reviewed Sep 14, 2018

View reviewed changes

Comment thread samples/productSearch/similarProducts.v1p3beta1.js

beccasaurus reviewed Sep 14, 2018

View reviewed changes

Comment thread samples/productSearch/similarProducts.v1p3beta1.js

nirupa-kumar closed this Sep 17, 2018

Conversation

nirupa-kumar commented Sep 11, 2018

Product Search (v1p3beta1)

products.js

productSets.js

–> Products in productSets.js

referenceImages.js

similarProducts.js

importProductSets.js

Uh oh!

googlebot commented Sep 11, 2018

Uh oh!

nirupa-kumar commented Sep 11, 2018

Uh oh!

codecov Bot commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

googlebot commented Sep 13, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

googlebot commented Sep 13, 2018

Uh oh!

beccasaurus commented Sep 14, 2018

Uh oh!

JustinBeckwith commented Sep 14, 2018

Uh oh!

nirupa-kumar commented Sep 14, 2018

Uh oh!

beccasaurus commented Sep 14, 2018

Uh oh!

beccasaurus commented Sep 14, 2018

Uh oh!

googlebot commented Sep 14, 2018

Uh oh!

googlebot commented Sep 14, 2018

Uh oh!

beccasaurus commented Sep 14, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nirupa-kumar commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Sep 11, 2018 •

edited

Loading