This repository was archived by the owner on Jul 20, 2023. It is now read-only.
build: configure Windows build on Kokoro#165
Merged
JustinBeckwith merged 5 commits intomasterfrom Aug 10, 2018
Merged
Conversation
ghost
assigned
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 83 83
=====================================
Hits 83 83Continue to review full report at Codecov.
|
Contributor
|
I just noticed something - can you confirm that codecov is successfully reporting stats? |
Contributor
Author
|
We also need to figure out how to upload codecov to codecov.io. The npm module that does it only works out of the box for CircleCI (and others). |
Contributor
Author
|
...or do you mean codecov is not reporting the entire src/? |
JustinBeckwith
approved these changes
Aug 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also require internal approvals.