This repository was archived by the owner on Jul 20, 2023. It is now read-only.
chore(samples): removing migrated samples#1083
Merged
Conversation
|
Here is the summary of changes. You are about to delete 62 region tags.
This comment is generated by snippet-bot.
|
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
Bot
added
size: xl
Contributor
|
I just clicked the box to refresh the comment from SnippetBot — I want to make sure we resolve all instances of samples in use safely so we don't end up with broken links. Are all CLs related to this migration merged? |
meredithslota
added
the
do not merge
Contributor
|
Sent cl/501606662 to address the |
Contributor
|
Sent cl/501614555 to address the remaining region_tag updates. Let's wait for these to be merged and for SnippetBot to be happy before deleting these. |
Contributor
|
Both CLs are submitted, just waiting for the SnippetBot index to pick up changes and make sure I didn't miss any. |
Contributor
|
Ok, looks like I missed two region tags somewhere, so will send another CL updating those. Stay tuned. :) |
Contributor
|
Sent cl/501719994. |
Contributor
|
Ok, last CL has been submitted, just waiting for SnippetBot index to update. The samples test is failing (expected) so I think we also might want to remove the samples tests in this PR (or, ok to merge as-is and remove the tests in a follow-up PR). |
Contributor
|
SnippetBot is happy! Removing the |
meredithslota
removed
the
do not merge
meredithslota
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples have been moved here:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/vision