Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

build(samples test): added imageContext to ImprovedRequest#1069

Merged
sofisl merged 6 commits intomainfrom
ImprovedRequest
Oct 4, 2022
Merged

build(samples test): added imageContext to ImprovedRequest#1069
sofisl merged 6 commits intomainfrom
ImprovedRequest

Conversation

@galz10
Copy link
Copy Markdown
Contributor

@galz10 galz10 commented Oct 4, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #963

@galz10 galz10 requested review from a team October 4, 2022 17:07
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: vision Issues related to the googleapis/nodejs-vision API. labels Oct 4, 2022
@product-auto-label product-auto-label Bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Oct 4, 2022
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Oct 4, 2022
@sofisl sofisl changed the title fix: added imageContext to ImprovedRequest build(samples test): added imageContext to ImprovedRequest Oct 4, 2022
@sofisl sofisl merged commit 5c6aaca into main Oct 4, 2022
@sofisl sofisl deleted the ImprovedRequest branch October 4, 2022 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: vision Issues related to the googleapis/nodejs-vision API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete ImprovedRequest TypeScript interface

2 participants