Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

docs(samples): add Video Stitcher slate and CDN key code samples and tests#6

Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
irataxy:main
Jun 10, 2022
Merged

docs(samples): add Video Stitcher slate and CDN key code samples and tests#6
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
irataxy:main

Conversation

@irataxy
Copy link
Copy Markdown
Contributor

@irataxy irataxy commented Jun 10, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b:202972969

@product-auto-label product-auto-label Bot added size: l Pull request size is large. samples Issues that are directly related to samples. labels Jun 10, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 10, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2022
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jun 10, 2022
alexander-fenster
alexander-fenster reviewed Jun 10, 2022
View reviewed changes
Comment thread samples/listCdnKeys.js Outdated
@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Jun 10, 2022

@irataxy, would you mind adding your team in the .repo-metadata.json file as codeowners as well?

alexander-fenster
alexander-fenster approved these changes Jun 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider changing list methods to their async iterator versions.

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jun 10, 2022

Warning: This pull request is touching the following templated files:

@alexander-fenster alexander-fenster added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2022
@alexander-fenster alexander-fenster changed the title feat: add Video Stitcher slate and CDN key code samples and tests docs(samples): add Video Stitcher slate and CDN key code samples and tests Jun 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit ed70ba7 into googleapis:main Jun 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irataxy @sofisl @alexander-fenster @bcoe