This repository was archived by the owner on Jul 20, 2023. It is now read-only.
docs(samples): add try/catch to delete operations in testing#19
Merged
irataxy merged 4 commits intogoogleapis:mainfrom Jun 23, 2022
irataxy:main
Merged
docs(samples): add try/catch to delete operations in testing#19irataxy merged 4 commits intogoogleapis:mainfrom irataxy:main
irataxy merged 4 commits intogoogleapis:mainfrom
irataxy:main
Conversation
product-auto-label
Bot
added
size: s
irataxy
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
sofisl
suggested changes
Jun 15, 2022
Contributor
…ces over an hour old, move create and delete operations to before and after hooks in each test suite
product-auto-label
Bot
added
size: l
irataxy
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
product-auto-label
Bot
added
size: m
sofisl
approved these changes
Jun 16, 2022
product-auto-label
Bot
added
the
api: videostitcher
| } | ||
| ); | ||
| } catch (err) { | ||
| if (err.message.includes('NOT_FOUND')) { |
There was a problem hiding this comment.
Does the error object have a status to check the http status code? Might be cleaner than checking the message.
alclee-google
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b:202972969
Fixes: #17
Fixes #18