Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Check in synth script and update google-gax#51

Merged
jkwlui merged 5 commits intogoogleapis:masterfrom
jkwlui:check-in-synth
Jun 28, 2018
Merged

Check in synth script and update google-gax#51
jkwlui merged 5 commits intogoogleapis:masterfrom
jkwlui:check-in-synth

Conversation

@jkwlui
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui commented Jun 26, 2018

Fixes #48
ref: googleapis/google-cloud-node#2837

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2018
@ghost ghost assigned jkwlui Jun 26, 2018
@jkwlui jkwlui requested a review from a team June 26, 2018 23:02
crwilcox
crwilcox approved these changes Jun 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the generated test is adding an unused helper. If you add that to synth.py to strip this should pass CI.

@jkwlui
Copy link
Copy Markdown
Contributor Author

jkwlui commented Jun 27, 2018

@crwilcox any idea how I might strip a block of code?

@crwilcox
Copy link
Copy Markdown
Contributor

crwilcox commented Jun 27, 2018

@kinwa91 I would do something like the below to find the function and replace it with the empty string.

s.replace('file.js',  'function mockSimpleGrpcMethod.*\n(.*\n)*?}', '')

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Jun 27, 2018

If the generator is creating invalid code, that's a P0. Please file a P0 here:
https://github.com/googleapis/gapic-generator

Make sure to add the yoshi and priority: P0 labels.

@jkwlui jkwlui mentioned this pull request Jun 27, 2018
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #51   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           7      7           
=====================================
  Hits            7      7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc5741...dc5f424. Read the comment docs.

@jkwlui
Copy link
Copy Markdown
Contributor Author

jkwlui commented Jun 27, 2018 •
edited
Loading

@crwilcox You are the regex master! It works great, Thanks!

@ghost ghost assigned JustinBeckwith Jun 28, 2018
@jkwlui jkwlui merged commit 6bf4b83 into googleapis:master Jun 28, 2018
@jkwlui jkwlui deleted the check-in-synth branch June 28, 2018 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JustinBeckwith JustinBeckwith

@jkwlui jkwlui

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkwlui @crwilcox @JustinBeckwith @googlebot