Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Update Cloud Tasks Sample#67

Merged
jkwlui merged 15 commits intogoogleapis:masterfrom
averikitsch:cloud-tasks
Sep 13, 2018
Merged

Update Cloud Tasks Sample#67
jkwlui merged 15 commits intogoogleapis:masterfrom
averikitsch:cloud-tasks

Conversation

@averikitsch
Copy link
Copy Markdown
Contributor

@averikitsch averikitsch commented Sep 11, 2018

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2018
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Sep 12, 2018

lint is failing

@jkwlui jkwlui self-requested a review September 12, 2018 20:57
@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Sep 12, 2018

nodejs-repo-tool requires a quickstart.js with the region tag [tasks_quickstart] in order to display a quickstart section in README.md

I notice you have a server.js which is an express app that doesn't do anything with the Tasks API and it's marked [cloud_tasks_appengine_quickstart]. Is createTask.js a more appropriate quickstart sample, or do we not prefer to have a quickstart section here?

Nevermind, I notice you have a custom samples/README.md. However I believe when generating docs on dev-site we still expect to have a [tasks_quickstart] region tag somewhere.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 12, 2018

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           5      5           
=====================================
  Hits            5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7853e7...f7a77e8. Read the comment docs.

@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Sep 13, 2018

We also need to set the default version back to v2beta3 and cut a release.

@jkwlui jkwlui merged commit 615fe57 into googleapis:master Sep 13, 2018
@averikitsch averikitsch deleted the cloud-tasks branch September 13, 2018 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants