Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

fix(issue-654): wrapping param inSeconds with parseInt to ensure correct addition#655

Merged
averikitsch merged 1 commit intomainfrom
fix/seconds-invalid-argument
Sep 13, 2022
Merged

fix(issue-654): wrapping param inSeconds with parseInt to ensure correct addition#655
averikitsch merged 1 commit intomainfrom
fix/seconds-invalid-argument

Conversation

@pattishin
Copy link
Copy Markdown
Contributor

@pattishin pattishin commented Sep 13, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #654 🦕

@pattishin pattishin added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 13, 2022
@pattishin pattishin self-assigned this Sep 13, 2022
@pattishin pattishin requested review from a team September 13, 2022 04:37
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: cloudtasks Issues related to the googleapis/nodejs-tasks API. labels Sep 13, 2022
@pattishin pattishin removed their assignment Sep 13, 2022
@averikitsch averikitsch merged commit efdb0b8 into main Sep 13, 2022
@averikitsch averikitsch deleted the fix/seconds-invalid-argument branch September 13, 2022 15:38
@release-please release-please Bot mentioned this pull request Sep 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@averikitsch averikitsch averikitsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudtasks Issues related to the googleapis/nodejs-tasks API. size: xs Pull request size is extra small. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thrown Invalid Argument while populating 'inSeconds' param to createHttpTask.js

2 participants

@pattishin @averikitsch