Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

fix(issue-640): adding headers in task request samples#642

Merged
averikitsch merged 8 commits intomainfrom
fix/issue-640
Sep 15, 2022
Merged

fix(issue-640): adding headers in task request samples#642
averikitsch merged 8 commits intomainfrom
fix/issue-640

Conversation

@pattishin
Copy link
Copy Markdown
Contributor

@pattishin pattishin commented Aug 18, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #640 🦕

Affects:

@pattishin
fix: adding headers in task request
427063a 
refactor: updating readme with same fix
@pattishin pattishin requested review from a team August 18, 2022 18:36
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Aug 18, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Aug 18, 2022

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label Bot added the api: cloudtasks Issues related to the googleapis/nodejs-tasks API. label Aug 18, 2022
@pattishin pattishin changed the title fix(issue-640): adding headers in task request fix(issue-640): adding headers in task request samples Aug 18, 2022
averikitsch
averikitsch suggested changes Aug 18, 2022
View reviewed changes
Comment thread samples/createHttpTask.js Outdated
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 19, 2022
@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2022
@averikitsch averikitsch merged commit d334d0d into main Sep 15, 2022
@averikitsch averikitsch deleted the fix/issue-640 branch September 15, 2022 17:33
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 15, 2022
@release-please release-please Bot mentioned this pull request Sep 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@averikitsch averikitsch averikitsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudtasks Issues related to the googleapis/nodejs-tasks API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation/Examples should include Content-Type header

2 participants

@pattishin @averikitsch