Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Documentation/Examples should include Content-Type header #640

@Mtillmann

Description

@Mtillmann

Hi Guys, the examples omit the Content-Type header for the httpRequest while using POST body. Many http frameworks will ignore the POST body if no Content-Type-Request-Header is set. I think its bad practice to provide examples that probably wont work as expected because that header is missing.

Environment details

  • OS: GCF
  • Node.js version: 16
  • npm version: 8.13.2
  • @google-cloud/tasks version: ^3.0.0

Steps to reproduce

  1. follow example
  2. receive no req.body in URL that's being called (in my case a GCF using the node/http variety (express))

Metadata

Metadata

Assignees

Labels

api: cloudtasksIssues related to the googleapis/nodejs-tasks API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions