Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

feat: v4beta1 application support and proto sync#29

Merged
jkwlui merged 2 commits intomasterfrom
autosynth
Mar 29, 2019
Merged

feat: v4beta1 application support and proto sync#29
jkwlui merged 2 commits intomasterfrom
autosynth

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Mar 28, 2019 •
edited by callmehiphop
Loading

BREAKING CHANGE: In addition to the v4beta client features, this change also removes support for any string template paths relating to projectPath and companyPath, it now supports tenantPath and companyOldPath instead.

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:e3c054a2fb85a12481c722af616c7fb6f1d02d862248385eecbec3e4240ebd1e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/talent/artman_talent_v4beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/talent-v4beta1.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test-grpcjs.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test-grpcjs.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
Skipping: README.md
codecov.yaml
renovate.json
synthtool > Replaced 'https:\\/\\/cloud\\.google\\.com[\\s\\*]*http:\\/\\/(.*)[\\s\\*]*\\)' in src/v4beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced 'toISOString\\]' in src/v4beta1/doc/google/protobuf/doc_timestamp.js.
synthtool > Replaced '"https:\\/\\/www\\.google\\.com"' in src/v4beta1/doc/google/cloud/talent/v4beta1/doc_company.js.

> [email protected] install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using needle for node-pre-gyp https download 
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

> [email protected] postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1107 packages from 1304 contributors and audited 6725 packages in 23.809s
found 3 vulnerabilities (1 low, 2 moderate)
  run `npm audit fix` to fix them, or `npm audit` for details

> @google-cloud/[email protected] fix /tmpfs/src/git/autosynth/working_repo
> eslint --fix '**/*.js'

synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
@callmehiphop callmehiphop changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. feat: create v4beta1 client Mar 28, 2019
@callmehiphop callmehiphop changed the title feat: create v4beta1 client feat: create v4beta1 client and proto updates Mar 28, 2019
@callmehiphop callmehiphop changed the title feat: create v4beta1 client and proto updates feat: v4beta1 application support and proto sync Mar 28, 2019
@callmehiphop
Copy link
Copy Markdown

callmehiphop commented Mar 28, 2019

The doc failure here is because it's looking for a link that has yet to be committed to master. I'm pretty ignorant to Kokoro but it seems like we shouldn't be testing against master, but the branch being PR'd instead?

Aside from that, this is one hefty PR - it includes new features, breaking changes and what looks like some analytics code? I've updated the PR overview to include a mention of the breaking changes, so whoever merges should make sure it (or something similar) is included in the extended message.

@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Mar 28, 2019

The link I see failing - [404] https://github.com/googleapis/googleapis/blob/master/google/cloud/talent/v4beta1/resume_service.proto

is at the googleapis/googleapis repo. Since this generation is based off of it, we need to understand why it's missing there.

@jkwlui
Copy link
Copy Markdown
Contributor

jkwlui commented Mar 28, 2019

I see the problem now. Some files actually got removed since this generation:

	deleted:    protos/google/cloud/talent/v4beta1/resume_service.proto
	deleted:    src/v4beta1/doc/google/cloud/talent/v4beta1/doc_resume_service.js
	deleted:    src/v4beta1/resume_service_client.js
	deleted:    src/v4beta1/resume_service_client_config.json

But neither synthtool/gapic remove files that are not suppose to be there, we didn't catch that.

I had to rm -rf protos src/v4beta1 and run synthtool locally to see that they were removed.

@jkwlui jkwlui mentioned this pull request Mar 28, 2019
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2019 •
edited
Loading

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf1008...3fe85d0. Read the comment docs.

@jkwlui jkwlui added the semver: major Hint for users that this is an API breaking change. label Mar 29, 2019
@jkwlui jkwlui merged commit 6fc7d74 into master Mar 29, 2019
@jkwlui jkwlui deleted the autosynth branch March 29, 2019 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

1 more reviewer

@jkwlui jkwlui jkwlui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @callmehiphop @jkwlui @googlebot