Fix: Spelling correction "targetting"#266
Fix: Spelling correction "targetting"#266jainsamyak wants to merge 1 commit intogoogleapis:masterfrom
Conversation
Spelling correction for targetting to targeting
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 17 17
Lines 15384 15384
Branches 528 528
=======================================
Hits 15031 15031
Misses 341 341
Partials 12 12 Continue to review full report at Codecov.
|
|
@googlebot I signed it! |
JustinBeckwith
left a comment
There was a problem hiding this comment.
Greetings, and thank you for the PR! However, your README is in another castle. This README is auto generated by a robot, which does some other templating tricks. The source this is generated from lives here:
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/README.md
Would you be willing to float a patch there? Thank you so much!
|
Hi Justin, Thanks. |
|
@jainsamyak thank you for the patch 👌 this file is actually templated, if we fix the spelling mistake here it will fix every one of our READMEs. Edit: like @JustinBeckwith says. |
I've created a pull request for the same here: googleapis/synthtool#852 |
Spelling correction for targetting to targeting
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #267 🦕