Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

Fix: Spelling correction "targetting"#266

Closed
jainsamyak wants to merge 1 commit intogoogleapis:masterfrom
jainsamyak:patch-1
Closed

Fix: Spelling correction "targetting"#266
jainsamyak wants to merge 1 commit intogoogleapis:masterfrom
jainsamyak:patch-1

Conversation

@jainsamyak
Copy link
Copy Markdown

@jainsamyak jainsamyak commented Nov 16, 2020

Spelling correction for targetting to targeting

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #267 🦕

Spelling correction for targetting to targeting
@jainsamyak jainsamyak requested a review from a team November 16, 2020 06:21
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Nov 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 16, 2020
@product-auto-label product-auto-label Bot added the api: jobs Issues related to the googleapis/nodejs-talent API. label Nov 16, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2020

Codecov Report

Merging #266 (d110222) into master (f12577e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          17       17           
  Lines       15384    15384           
  Branches      528      528           
=======================================
  Hits        15031    15031           
  Misses        341      341           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12577e...d110222. Read the comment docs.

@jainsamyak
Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 16, 2020
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings, and thank you for the PR! However, your README is in another castle. This README is auto generated by a robot, which does some other templating tricks. The source this is generated from lives here:
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/README.md

Would you be willing to float a patch there? Thank you so much!

@jainsamyak
Copy link
Copy Markdown
Author

Hi Justin,
Thanks for the helpful tip! I'll open a patch for that file instead.

Thanks.

@bcoe
Copy link
Copy Markdown

bcoe commented Nov 16, 2020

@jainsamyak thank you for the patch 👌 this file is actually templated, if we fix the spelling mistake here it will fix every one of our READMEs.

Edit: like @JustinBeckwith says.

@jainsamyak
Copy link
Copy Markdown
Author

Greetings, and thank you for the PR! However, your README is in another castle. This README is auto generated by a robot, which does some other templating tricks. The source this is generated from lives here:
https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/README.md

Would you be willing to float a patch there? Thank you so much!

I've created a pull request for the same here: googleapis/synthtool#852
I think we can close this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: jobs Issues related to the googleapis/nodejs-talent API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: "targetting" typo

3 participants