This repository was archived by the owner on Mar 3, 2026. It is now read-only.

samples: changed PAP unspecified to inherited#1614

Merged

bcoe merged 7 commits intomainfrom

shaffeeullah/PAPInherited

Sep 29, 2021

Contributor

shaffeeullah commented Sep 24, 2021 •

edited

Loading

Fixes #1616


          feat: changed PAP unspecified to inherited

0eaed25

shaffeeullah added the do not merge label

shaffeeullah requested review from a team

September 24, 2021 17:43

product-auto-label Bot added api: storage samples labels

snippet-bot Bot commented Sep 24, 2021 •

edited

Loading

Here is the summary of changes.

You are about to add 1 region tag.

samples/setPublicAccessPreventionInherited.js:24, tag storage_set_public_access_prevention_inherited

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

google-cla Bot added the cla: yes label

shaffeeullah requested a review from tritone

September 24, 2021 17:44


          🦉 Updates from OwlBot

4ae14b2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

tritone reviewed

View reviewed changes

Contributor

tritone left a comment

Couple small things, generally seems fine!

samples/setPublicAccessPreventionInherited.js

samples/system-test/buckets.test.js Outdated

                 assert.ok(metadata.iamConfiguration.publicAccessPrevention);
               });
-              it('should set public access prevention to unspecified', async () => {

Contributor

tritone Sep 24, 2021

The test for the unspecified sample should stay until we remove it from the docs.

Contributor Author

shaffeeullah Sep 27, 2021

this test needs to be deleted because it is failing. (setting it to unspecified is returning inherited)

system-test/storage.ts Outdated


          responded to PR comments

4f7c2a0

generated-files-bot Bot commented Sep 24, 2021 •

edited

Loading

Warning: This pull request is touching the following templated files:

.github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool
README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

shaffeeullah requested a review from tritone

September 24, 2021 21:20

tritone approved these changes

View reviewed changes

Contributor

tritone left a comment

Thanks!

ddelgrosso1 approved these changes

View reviewed changes

JustinBeckwith approved these changes

View reviewed changes

shaffeeullah added 2 commits

September 27, 2021 16:35


          Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

09abb1e

…feeullah/PAPInherited


          removed unused var

6478d80

shaffeeullah added kokoro:force-run and removed do not merge labels

yoshi-kokoro removed the kokoro:force-run label


          build: slightly tweaked doc test logic

259df53

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no and removed cla: yes labels

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

bcoe added the owlbot:ignore label

bcoe force-pushed the shaffeeullah/PAPInherited branch from 74a74f6 to 259df53 Compare

September 29, 2021 20:54

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

bcoe added cla: yes and removed cla: no labels

bcoe force-pushed the shaffeeullah/PAPInherited branch from 74a74f6 to 259df53 Compare

September 29, 2021 21:13

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no and removed cla: yes labels


          Merge branch 'main' into shaffeeullah/PAPInherited

91238c3

google-cla Bot commented Sep 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

bcoe added cla: yes do not merge and removed cla: no labels

bcoe mentioned this pull request

build(node): run linkinator against index.html googleapis/synthtool#1227

Merged

bcoe removed the do not merge label

bcoe merged commit 192703f into main

bcoe deleted the shaffeeullah/PAPInherited branch

September 29, 2021 22:31

ddelgrosso1 pushed a commit to ddelgrosso1/nodejs-storage that referenced this pull request


          samples: changed PAP unspecified to inherited (googleapis#1614)

93460a3

ddelgrosso1 pushed a commit that referenced this pull request


          samples: changed PAP unspecified to inherited (#1614)

3402ef1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage cla: yes owlbot:ignore samples