Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

test: fix precondition test#1481

Merged
shaffeeullah merged 4 commits intogoogleapis:masterfrom
tritone:precon-test
Jun 7, 2021
Merged

test: fix precondition test#1481
shaffeeullah merged 4 commits intogoogleapis:masterfrom
tritone:precon-test

Conversation

@tritone
Copy link
Copy Markdown
Contributor

@tritone tritone commented Jun 4, 2021

This test matches the exact error string from the service, which
has changed. Using the reason instead should be more robust.

Same as googleapis/java-storage#861

Fixes #1480

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

This test matches the exact error string from the service, which
has changed. Using the reason instead should be more robust.

Same as googleapis/java-storage#861

Fixes googleapis#1480
@tritone tritone requested review from a team June 4, 2021 04:21
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 4, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@tritone
Copy link
Copy Markdown
Contributor Author

tritone commented Jun 4, 2021

Going to pair with @shaffeeullah later today on getting this working correctly.

@tritone tritone marked this pull request as draft June 4, 2021 16:54
@tritone tritone marked this pull request as ready for review June 7, 2021 01:28
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@shaffeeullah shaffeeullah merged commit 3cb4780 into googleapis:master Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage file generations: should throw an error Precondition Failed on overwrite with version 0, then save file with and without resumable failed

3 participants