Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

docs: redirect EMULATOR_HOST users to apiEndpoint - #1432

Merged
shaffeeullah merged 1 commit into
masterfrom
shaffeeullah/redirectEmulatorHostUsersToApiEndpoint
Mar 30, 2021
Merged

shaffeeullah merged 1 commit into
masterfrom
shaffeeullah/redirectEmulatorHostUsersToApiEndpoint

Conversation

@shaffeeullah

Copy link
Copy Markdown
Contributor

Fixes #1314 🦕

@shaffeeullah
shaffeeullah requested review from a team March 30, 2021 22:35
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 30, 2021
@shaffeeullah
shaffeeullah requested a review from frankyn March 30, 2021 22:35
@codecov

codecov Bot commented Mar 30, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #1432 (c651e0e) into master (5792a3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          14       14           
  Lines       12161    12163    +2     
  Branches      530      604   +74     
=======================================
+ Hits        12052    12054    +2     
  Misses        109      109           
Impacted Files Coverage Δ
src/storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5792a3c...c651e0e. Read the comment docs.

@shaffeeullah
shaffeeullah merged commit bd9ef18 into master Mar 30, 2021
@shaffeeullah
shaffeeullah deleted the shaffeeullah/redirectEmulatorHostUsersToApiEndpoint branch March 30, 2021 23:27
gcf-owl-bot Bot added a commit that referenced this pull request May 5, 2022
* build: update auto-approve file to v2

Source-Link: googleapis/synthtool@19eb6fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b9e4584a1fe3c749e3c37c92497b13dce653b2e694f0261f0610eb0e15941357
gcf-merge-on-green Bot pushed a commit that referenced this pull request May 6, 2022
#1912)

* build: update auto-approve file to v2

Source-Link: googleapis/synthtool@19eb6fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b9e4584a1fe3c749e3c37c92497b13dce653b2e694f0261f0610eb0e15941357
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

baseurl is not quite right when using STORAGE_EMULATOR_HOST

2 participants