Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: allow ignoring 404 errors during delete() operations#1347

Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom
stephenplusplus:spp--1235
Dec 2, 2020
Merged

feat: allow ignoring 404 errors during delete() operations#1347
stephenplusplus merged 2 commits intogoogleapis:masterfrom
stephenplusplus:spp--1235

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus commented Dec 1, 2020

Fixes #1235

@stephenplusplus stephenplusplus requested a review from a team December 1, 2020 18:34
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Dec 1, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@stephenplusplus stephenplusplus mentioned this pull request Dec 1, 2020
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #1347 (1c986ba) into master (cbb2c25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11809    11815    +6     
  Branches      595      595           
=======================================
+ Hits        11692    11698    +6     
  Misses        117      117
Impacted Files Coverage Δ
src/bucket.ts 99.53% <100.00%> (+<0.01%) ⬆️
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb2c25...1c986ba. Read the comment docs.

@AVaksman
Copy link
Copy Markdown
Contributor

AVaksman commented Dec 2, 2020

Do DeleteFileOptions and DeleteBucketOptions interfaces need to be updated?

@shaffeeullah
Copy link
Copy Markdown
Contributor

shaffeeullah commented Dec 2, 2020

Should there be system/unit tests for this functionality?

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

stephenplusplus commented Dec 2, 2020

@shaffeeullah I don't believe we should do that here, as that testing is done in the common library, where the actual code for the ignoreNotFound option lives. We don't even have a function body for "delete()" in this layer-- it is entirely defined and executed from the common library's ServiceObject.prototype.delete method.

@stephenplusplus stephenplusplus merged commit dab0e7d into googleapis:master Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laljikanjareeya laljikanjareeya Awaiting requested review from laljikanjareeya

@AVaksman AVaksman Awaiting requested review from AVaksman

1 more reviewer

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FR: Add File.delete options property to count missing file as success

3 participants

@stephenplusplus @AVaksman @shaffeeullah