Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: set customEndpoint for custom environments - #1316

Merged
stephenplusplus merged 4 commits into
googleapis:masterfrom
stephenplusplus:spp--1315
Oct 29, 2020
Merged

stephenplusplus merged 4 commits into
googleapis:masterfrom
stephenplusplus:spp--1315

Conversation

@stephenplusplus

Copy link
Copy Markdown
Contributor

Fixes #1315

@google-cloud/common has an option, customEndpoint. When set to true, the authentication step is bypassed. We should be setting this for the user when they aren't making requests to the GCS servers:

  • when the environment variable STORAGE_EMULATOR_HOST is defined
  • when the user sets "options.apiEndpoint"

@stephenplusplus
stephenplusplus requested a review from a team October 19, 2020 14:53
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 20, 2020
@codecov

codecov Bot commented Oct 27, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #1316 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11715    11719    +4     
  Branches      582      513   -69     
=======================================
+ Hits        11598    11602    +4     
  Misses        117      117           
Impacted Files Coverage Δ
src/storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca5d34...8474ff0. Read the comment docs.

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-expose customEndpoint configuration option

3 participants