This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Repository navigation
fix: set customEndpoint for custom environments - #1316
Merged
Merged
Conversation
JustinBeckwith
approved these changes
Oct 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 14 14
Lines 11715 11719 +4
Branches 582 513 -69
=======================================
+ Hits 11598 11602 +4
Misses 117 117
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1315
@google-cloud/commonhas an option,customEndpoint. When set totrue, the authentication step is bypassed. We should be setting this for the user when they aren't making requests to the GCS servers:STORAGE_EMULATOR_HOSTis defined