This repository was archived by the owner on Mar 3, 2026. It is now read-only.
fix(types): add CreateBucketRequest.storageClass#1299
Merged
stephenplusplus merged 1 commit intomasterfrom Sep 21, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 14 14
Lines 11579 11580 +1
Branches 529 529
=======================================
+ Hits 11462 11463 +1
Misses 117 117
Continue to review full report at Codecov.
|
Contributor
laljikanjareeya
left a comment
laljikanjareeya
left a comment
There was a problem hiding this comment.
@stephenplusplus do we need this as all the classes available on the create bucket request
You can create bucket with storage class as below:
await storage.createBucket(bucketName, {
[storageClassName]: true,
});
Contributor
Author
|
Yes, that is our decoration to make things easier for the user, but we should always handle the REST-defined input as well. |
laljikanjareeya
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1248
The
CreateBucketRequestinterface was not accepting thestorageClassstring.