This repository was archived by the owner on Mar 3, 2026. It is now read-only.
chore: update createBucketRequest in createNewBucket.js#1248
Closed
kembala wants to merge 2 commits intogoogleapis:masterfrom
Closed
chore: update createBucketRequest in createNewBucket.js#1248kembala wants to merge 2 commits intogoogleapis:masterfrom
kembala wants to merge 2 commits intogoogleapis:masterfrom
Conversation
Example is outdated as the parameter type is:
}
```
export interface CreateBucketRequest {
archive?: boolean;
coldline?: boolean;
cors?: Cors[];
dra?: boolean;
multiRegional?: boolean;
nearline?: boolean;
regional?: boolean;
requesterPays?: boolean;
retentionPolicy?: object;
standard?: boolean;
userProject?: string;
location?: string;
versioning?: Versioning;
}
```
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
google-cla
Bot
added
the
cla: no
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 14 14
Lines 11579 11579
Branches 529 597 +68
=======================================
Hits 11462 11462
Misses 117 117 Continue to review full report at Codecov.
|
sofisl
changed the title
sofisl
approved these changes
Jul 16, 2020
Contributor
|
Hi @kemenesbalazs, thanks for your contribution! Before we can merge, can you sign the CLA? (see comment above). Thanks! |
Contributor
|
I think this is a TypeScript issue. We should definitely be supporting |
product-auto-label
Bot
added
the
api: storage
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it!
…On Thu, Sep 17, 2020, 22:04 google-cla[bot] ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fnodejs-storage%2Fpull%2F1248>
for more info*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW3UWC3DICZ3PIKGXNZOS3SGJTWHANCNFSM4O4CD22A>
.
|
google-cla
Bot
added
cla: yes
bcoe
added
the
do not merge
stephenplusplus
added a commit
that referenced
this pull request
Sep 21, 2020
Contributor
|
@kemenesbalazs Thank you for pointing this out. The real issue was that the TypeScript interface was not allowing |
stephenplusplus
added a commit
that referenced
this pull request
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example is outdated as the parameter type is:
}