Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

Clean-up for gcs-resumable-upload #1743

Closed

Description

@danielbankhead

Now that gcs-resumable-upload has been merged into this library (#1736), we should consider a refactor:

  • Rename src/gcs-resumable-media/index.ts to src/gcs-resumable-upload.ts
  • Remove unnecessary dependencies in favor of native dependencies:
    • pumpify -> Stream
    • is-stream -> Stream
    • streamEvents (remove, unnecessary)
  • Tighten gcs-resumable-upload integration with File (shared type definitions, removing things that are optional that File wouldn't use, etc.)

Activity

  1. changed the title [-]Clean-up/Refactor for `gcs-resumable-upload`[/-] [+]Clean-up for `gcs-resumable-upload`[/+] on Jan 7, 2022
  2. added
    type: cleanupAn internal cleanup or hygiene concern.
    and removed
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    on Feb 28, 2022
  3. danielduhh commented on Feb 28, 2022

    @danielduhh
    Contributor

    FYI @shaffeeullah @danielbankhead , I made this a checklist so we can track what we've done so far

  4. danielbankhead commented on Apr 27, 2022

    @danielbankhead
    ContributorAuthor

    AbortController isn't native in Node.js pre-v15... removing from the list for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: storageIssues related to the googleapis/nodejs-storage API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions