Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

chore: fixed export-to-storage.v1p1beta1 error#901

Merged
galz10 merged 2 commits intogoogleapis:mainfrom
galz10:gal-test
Jun 15, 2022
Merged

chore: fixed export-to-storage.v1p1beta1 error#901
galz10 merged 2 commits intogoogleapis:mainfrom
galz10:gal-test

Conversation

@galz10
Copy link
Copy Markdown
Contributor

@galz10 galz10 commented Jun 15, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #885 🦕

@galz10 galz10 requested review from a team June 15, 2022 18:09
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: speech Issues related to the googleapis/nodejs-speech API. labels Jun 15, 2022
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 15, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 15, 2022
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2022
@galz10 galz10 requested a review from sofisl June 15, 2022 18:32
@yil532 yil532 self-requested a review June 15, 2022 18:32
yil532
yil532 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Copy Markdown

@yil532 yil532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galz10 galz10 merged commit c57a013 into googleapis:main Jun 15, 2022
@galz10 galz10 deleted the gal-test branch June 15, 2022 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@yil532 yil532 yil532 approved these changes

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: speech Issues related to the googleapis/nodejs-speech API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Speech-to-Text export to Cloud Storage : should export transcriptions failed

4 participants

@galz10 @yil532 @sofisl @yoshi-kokoro