Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

add synth.py and generate#244

Merged
crwilcox merged 5 commits intomasterfrom
regenerate-spanner
Jun 25, 2018
Merged

add synth.py and generate#244
crwilcox merged 5 commits intomasterfrom
regenerate-spanner

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox commented Jun 25, 2018

Fixes #183 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2018
@ghost ghost assigned crwilcox Jun 25, 2018
@JustinBeckwith
Copy link
Copy Markdown
Contributor

Thanks! You're going to need to update the latest version of google-gax for this to work :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2018

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1412   1412           
=====================================
  Hits         1412   1412
Impacted Files Coverage Δ
src/transaction.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b9dc1...1cb2701. Read the comment docs.

@crwilcox
Copy link
Copy Markdown
Contributor Author

this passed besides linter changes. I have submitted that commit.

@crwilcox crwilcox merged commit 1ad5797 into master Jun 25, 2018
@crwilcox crwilcox mentioned this pull request Jun 25, 2018
3 tasks
@jmdobry jmdobry deleted the regenerate-spanner branch October 16, 2018 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants