feat(spanner): add support for multiplexed session for r/w transactions by alkatrivedi · Pull Request #2351 · googleapis/nodejs-spanner

alkatrivedi · 2025-07-21T09:37:42Z

This PR introduces support for multiplexed sessions for read-write transactions.

The following public methods have been updated as part of this change:

getTransaction
runTransaction
runTransactionAsync
batchWriteAtLeastOnce

other methods which have been updated are:

makePooledRequest_
makePooledStreamingRequest_

In addition to the changes in the public API, the implementation has been fully tested to ensure correctness and stability.

To enable multiplexed session set the environment variable GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS and GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW to true

surbhigarg92 · 2025-07-24T05:25:30Z

Ideally with this PR every method should use session factory. Below are the methods which are not updated

CreateBatchTransaction - https://github.com/googleapis/nodejs-spanner/blob/main/src/database.ts#L909
batchWriteAtLeastOnce - https://github.com/googleapis/nodejs-spanner/blob/main/src/database.ts#L3610

surbhigarg92 · 2025-07-24T05:29:47Z

Ideally with this PR every method should use session factory. Below are the methods which are not updated

CreateBatchTransaction - https://github.com/googleapis/nodejs-spanner/blob/main/src/database.ts#L909 batchWriteAtLeastOnce - https://github.com/googleapis/nodejs-spanner/blob/main/src/database.ts#L3610

Also makePooledStreamingRequest_ and makePooledRequest_

test/database.ts

surbhigarg92 · 2025-07-24T05:38:41Z

test/mockserver/mockspanner.ts

+              (res.resultSet as protobuf.ResultSet).precommitToken =
+                precommitToken;


precommitToken is always retruned if session is multiplexed ?

yes, we will always get a precommitToken in the PartialResultSet if the multiplexed session is enabled

surbhigarg92 · 2025-07-24T05:40:25Z

test/mockserver/mockspanner.ts

    this.pushRequest(call.request!, call.metadata);
    this.simulateExecutionTime(this.beginTransaction.name)
      .then(() => {
+        this.begin = call.request.mutationKey ? true : false;


What does this begin mean here ? Is this for mutation only case?

yeah, I have changed the naming now to this.mutationOnly

surbhigarg92 · 2025-07-24T05:45:00Z

test/spanner.ts

+          // get the type of mutation key
+          const mutationType = Object.keys(selectedMutationKey!)[0];
+
+          // assert that mutation key is not insert


nit: this assert is not required, below should be enough

src/database.ts

surbhigarg92 · 2025-07-25T08:57:16Z

src/session-factory.ts

+  /**
+   * Retrieves a session for pooled request(via, makePooledRequest_), selecting the appropriate session type
+   * based on whether multiplexed sessions are enabled.
+   *
+   * If the multiplexed sessions are disabled, a session is retrieved from the regular session pool.
+   *
+   * @param {GetSessionCallback} callback The callback function.
+   */
+  getSessionForPooledRequest(callback: GetSessionCallback): void {
+    const getSessionFn = this.isMultiplexedRW
+      ? this.getSessionForReadWrite
+      : this.isMultiplexedPartitionOps
+        ? this.getSessionForPartitionedOps
+        : this.isMultiplexed
+          ? this.getSession
+          : this.pool_.getSession.bind(this.pool_);
+
+    getSessionFn(callback);
+  }
+


Why do we need this, I am not getting ?

based on our discussion over chat, I have removed this method

alkatrivedi requested a review from a team July 21, 2025 09:37

alkatrivedi requested a review from a team as a code owner July 21, 2025 09:37

product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jul 21, 2025

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2025

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 21, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 21, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2025

alkatrivedi force-pushed the mux-session-support branch from f75ccb3 to 7f0670b Compare July 22, 2025 07:25

product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jul 22, 2025

alkatrivedi force-pushed the mux-session-support branch from 7f0670b to 5434347 Compare July 22, 2025 10:03

alkatrivedi added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: xl Pull request size is extra large. labels Jul 22, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 22, 2025

alkatrivedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2025

alkatrivedi force-pushed the mux-session-support branch from 5434347 to 902df50 Compare July 22, 2025 10:56

product-auto-label bot added the size: xl Pull request size is extra large. label Jul 22, 2025

alkatrivedi force-pushed the mux-session-support branch from 9f9b5f3 to 006ca6a Compare July 23, 2025 10:48

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 23, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 23, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2025

alkatrivedi force-pushed the mux-session-support branch from 006ca6a to 510ba68 Compare July 23, 2025 11:10

sakthivelmanii previously approved these changes Jul 24, 2025

View reviewed changes

surbhigarg92 reviewed Jul 24, 2025

View reviewed changes

alkatrivedi added 2 commits July 25, 2025 10:58

feat(spanner): add support for multiplexed session for r/w transactions

7b131a2

test: commit retry logic

639b5e2

alkatrivedi dismissed sakthivelmanii’s stale review via 1ebf7fe July 25, 2025 05:29

alkatrivedi force-pushed the mux-session-support branch from e8256ec to 1ebf7fe Compare July 25, 2025 05:29

support in batch write

aa52698

alkatrivedi force-pushed the mux-session-support branch from 1ebf7fe to aa52698 Compare July 25, 2025 05:50

support to createBatchTransaction

2dfedc5

alkatrivedi force-pushed the mux-session-support branch from b9c2cef to 6be3719 Compare July 25, 2025 07:17

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2025

alkatrivedi force-pushed the mux-session-support branch from 4561cf9 to 505999b Compare July 25, 2025 07:44

surbhigarg92 reviewed Jul 25, 2025

View reviewed changes

refactor test

72dfd6a

alkatrivedi force-pushed the mux-session-support branch from 505999b to 72dfd6a Compare July 25, 2025 11:49

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2025

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2025

surbhigarg92 approved these changes Jul 28, 2025

View reviewed changes

Merge branch 'main' into mux-session-support

d8e5c2d

alkatrivedi merged commit 6a9f1a2 into main Jul 29, 2025
24 checks passed

alkatrivedi deleted the mux-session-support branch July 29, 2025 06:23

release-please bot mentioned this pull request Jul 29, 2025

chore(main): release 8.2.0 #2359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(spanner): add support for multiplexed session for r/w transactions#2351

feat(spanner): add support for multiplexed session for r/w transactions#2351
alkatrivedi merged 6 commits intomainfrom
mux-session-support

alkatrivedi commented Jul 21, 2025 •

edited

Loading

Uh oh!

surbhigarg92 commented Jul 24, 2025

Uh oh!

surbhigarg92 commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

surbhigarg92 Jul 24, 2025

Uh oh!

alkatrivedi Jul 25, 2025

Uh oh!

surbhigarg92 Jul 24, 2025

Uh oh!

alkatrivedi Jul 25, 2025 •

edited

Loading

Uh oh!

surbhigarg92 Jul 24, 2025

Uh oh!

alkatrivedi Jul 25, 2025

Uh oh!

Uh oh!

surbhigarg92 Jul 25, 2025

Uh oh!

alkatrivedi Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		(res.resultSet as protobuf.ResultSet).precommitToken =
		precommitToken;

Conversation

alkatrivedi commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

surbhigarg92 commented Jul 24, 2025

Uh oh!

surbhigarg92 commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

surbhigarg92 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

alkatrivedi Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

surbhigarg92 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

alkatrivedi Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

surbhigarg92 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

alkatrivedi Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

surbhigarg92 Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

alkatrivedi Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alkatrivedi commented Jul 21, 2025 •

edited

Loading

alkatrivedi Jul 25, 2025 •

edited

Loading