feat(spanner): add TPC support by alkatrivedi · Pull Request #2333 · googleapis/nodejs-spanner

alkatrivedi · 2025-06-24T09:18:51Z

This PR contains the code changes for supporting TPC in node client.

surbhigarg92 · 2025-06-30T07:03:39Z

src/index.ts

  [P in keyof T]: P extends U ? EnumKey<E> | null | undefined : T[P];
 };

+function getUniverseDomainOnly(options: SpannerOptions): string {


nit: rename to getUniverseDomain

surbhigarg92 · 2025-06-30T07:05:19Z

src/index.ts

  defaultTransactionOptions?: Pick<RunTransactionOptions, 'isolationLevel'>;
  observabilityOptions?: ObservabilityOptions;
  interceptors?: any[];
+  universe_domain?: string;


add the documentation for it

surbhigarg92 · 2025-06-30T07:08:12Z

src/index.ts

+      options?.universeDomain &&
+      options?.universe_domain !== options?.universeDomain
+    ) {
+      throw new Error(


I am not getting this , why do we have two different properties ?

at gax level we are handling both the options, which is why we are handling two different properties here as well

based on our offline discussion, we will handling this error in separate PR, hence I have removed this piece of code from here

src/index.ts

sakthivelmanii · 2025-06-30T16:57:00Z

src/index.ts

+ *
+ * This function checks for a universe domain in the following order:
+ * 1. The `universeDomain` property within the provided spanner options.
+ * 2. The `GOOGLE_CLOUD_UNIVERSE_DOMAIN` environment variable.


why is this required? is it a standard across all the libraries?

to make the implementation consistent with the gax library I am checkin domain via env as well

is it a standard across all the libraries?

otherwise no, if we see other database libraries, Bigtable is handling it(they have merged the PR as well), while BigQuery is not handling via env(they also have merged the PR)

@rahul2393 can you please confirm for Spanner Go client?

note: we are not merging this PR, the setup and implementation is just for manual testing

I can see that autogenerated clients are using the same env

sakthivelmanii · 2025-06-30T16:57:15Z

src/index.ts

+  /**
+   * The Trusted Cloud Domain (TPC) DNS of the service used to make requests.
+   */
+  universe_domain?: string;


why are we having two options.

because gax libraries are handling both the options
https://github.com/googleapis/gax-nodejs/blob/main/gax/src/clientInterface.ts#L43-#L44

I think we are asking clients to configure it. There's no compelling reasons for us to have both unless it's defined as standard across all the libraries.

I can see that autogenerated clients are also having two fields for same variable. Would you mind checking with gax or nodejs or TPC to understand the rational behind this decision?

sure let me check with the team

sakthivelmanii · 2025-06-30T17:15:02Z

src/index.ts

      options.sslCreds = grpc.credentials.createInsecure();
    }
+
+    const universeDomain = getDomain('spanner', options);


rename this. universeDomain usually used for googleapis.com. but result is spanner url.

src/index.ts

surbhigarg92 · 2025-07-03T08:50:23Z

src/index.ts

    );
    ensureInitialContextManagerSet();
    this._nthClientId = nextSpannerClientId();
+    this._universeDomain = getUniverseDomain(options);


why are we calling getUniverseDomain again here, save it the first time .

sakthivelmanii · 2025-07-04T06:58:59Z

src/index.ts

      options.sslCreds = grpc.credentials.createInsecure();
    }
+
+    const universeEndpoint = getUniverseDomain(options);


why do you need an extra variable?

we were calling getUniverseDomain(options) at two points:

const spannerUniverseEndpoint = 'spanner.' + getUniverseDomain(options); this._universeDomain = getUniverseDomain(options);

so now I am storing the value returned from the method getUniverseDomain in a single variable and using that variable on those two places

the change has been made with ref to this comment

alkatrivedi requested a review from a team June 24, 2025 09:18

alkatrivedi requested a review from a team as a code owner June 24, 2025 09:18

product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jun 24, 2025

alkatrivedi marked this pull request as draft June 24, 2025 09:19

alkatrivedi force-pushed the tpc-support branch 2 times, most recently from 67df505 to ddd6e8f Compare June 27, 2025 08:48

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 27, 2025

alkatrivedi marked this pull request as ready for review June 27, 2025 09:46

alkatrivedi force-pushed the tpc-support branch 2 times, most recently from 5d67c5a to ab63f1b Compare June 27, 2025 09:58

rahul2393 previously approved these changes Jun 30, 2025

View reviewed changes

alkatrivedi dismissed rahul2393’s stale review via ff9c579 June 30, 2025 05:14

surbhigarg92 reviewed Jun 30, 2025

View reviewed changes

sakthivelmanii reviewed Jun 30, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jun 30, 2025

alkatrivedi force-pushed the tpc-support branch 4 times, most recently from ad1ce47 to 5cea51f Compare June 30, 2025 16:52

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 30, 2025

sakthivelmanii reviewed Jun 30, 2025

View reviewed changes

alkatrivedi force-pushed the tpc-support branch from 5cea51f to d734ff4 Compare June 30, 2025 17:09

sakthivelmanii reviewed Jun 30, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

alkatrivedi force-pushed the tpc-support branch from d734ff4 to c7091c9 Compare July 1, 2025 07:08

product-auto-label bot added the size: xl Pull request size is extra large. label Jul 3, 2025

alkatrivedi force-pushed the tpc-support branch from 067754b to a68cbbc Compare July 3, 2025 08:12

product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jul 3, 2025

surbhigarg92 reviewed Jul 3, 2025

View reviewed changes

alkatrivedi force-pushed the tpc-support branch from 4b6ea12 to a0698d9 Compare July 3, 2025 09:09

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 3, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2025

surbhigarg92 previously approved these changes Jul 3, 2025

View reviewed changes

alkatrivedi dismissed surbhigarg92’s stale review via cdd7cf3 July 3, 2025 09:15

alkatrivedi force-pushed the tpc-support branch from a0698d9 to cdd7cf3 Compare July 3, 2025 09:15

surbhigarg92 previously approved these changes Jul 3, 2025

View reviewed changes

sakthivelmanii previously approved these changes Jul 3, 2025

View reviewed changes

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 3, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2025

alkatrivedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2025

alkatrivedi force-pushed the tpc-support branch from f85f3e6 to 218f218 Compare July 3, 2025 17:56

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 3, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 3, 2025

feat(spanner): add tpc support

89e7af5

sakthivelmanii reviewed Jul 4, 2025

View reviewed changes

sakthivelmanii approved these changes Jul 4, 2025

View reviewed changes

surbhigarg92 approved these changes Jul 4, 2025

View reviewed changes

release-please bot mentioned this pull request Jul 4, 2025

chore(main): release 8.1.0 #2305

Merged

Conversation

alkatrivedi commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alkatrivedi Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alkatrivedi commented Jun 24, 2025 •

edited

Loading

alkatrivedi Jun 30, 2025 •

edited

Loading