chore: sample for snapshot isolation by alkatrivedi · Pull Request #2265 · googleapis/nodejs-spanner

alkatrivedi · 2025-03-25T07:05:07Z

This PR contains sample for the Snapshot Isolation level support. Isolation level is being set to SERIALIZABLE at the client level which is getting overwritten by the isolation level REPEATABLE_READ set at the transaction level.

snippet-bot · 2025-03-25T07:05:12Z

Here is the summary of changes.

You are about to add 1 region tag.

samples/repeatable-reads.js:26, tag spanner_isolation_level

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

surbhigarg92 · 2025-03-25T07:10:14Z

samples/snapshot-isolation.js

+    // Gets a reference to a Cloud Spanner instance and database
+    const instance = spanner.instance(instanceId);
+    const database = instance.database(databaseId);
+    const snapshotIsolationOptionsForRequest = {


Suggested change

const snapshotIsolationOptionsForRequest = {

// The isolation level specified at the request level takes precedence over the isolation level configured at the client level.

const snapshotIsolationOptionsForRequest = {

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

generated-files-bot · 2025-03-26T11:28:15Z

Warning: This pull request is touching the following templated files:

README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

skuruppu · 2025-03-28T03:22:44Z

samples/snapshot-isolation.js

+  // [START spanner_isolation_level]
+  // Imports the Google Cloud Spanner client library
+  const {Spanner, protos} = require('@google-cloud/spanner');
+  const snapshotIsolationOptionsForClient = {


probably calls this isolationOptionsForClient.

skuruppu · 2025-03-28T03:23:54Z

samples/snapshot-isolation.js

+    defaultTransactionOptions: snapshotIsolationOptionsForClient,
+  });
+
+  function spannerSnapshotIsolation() {


I would call this runTransactionWithIsolationLevel().

skuruppu · 2025-03-28T03:24:25Z

samples/snapshot-isolation.js

+    const instance = spanner.instance(instanceId);
+    const database = instance.database(databaseId);
+    // The isolation level specified at the request level takes precedence over the isolation level configured at the client level.
+    const snapshotIsolationOptionsForRequest = {


Same here with naming, something like isolationOptionsForTransaction.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

skuruppu · 2025-04-02T02:00:10Z

samples/snapshot-isolation.js

Let's rename this to repeatable-read.js.

skuruppu · 2025-04-02T02:00:28Z

samples/README.md

+__Usage:__
+
+
+`node snapshot-isolation.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>`


Same here with naming: repeatable-read.js

skuruppu · 2025-04-02T02:02:03Z

samples/system-test/spanner.test.js

+  // isolation_level_option
+  it('should run read-write transaction with isolation level option set', () => {
+    const output = execSync(
+      `node snapshot-isolation.js ${INSTANCE_ID} ${DATABASE_ID} ${PROJECT_ID}`


Same here with naming.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…apis/nodejs-spanner into sample-snapshot-isolation

chore: sample for snapshot isolation

2a570b8

alkatrivedi requested a review from a team March 25, 2025 07:05

alkatrivedi requested a review from a team as a code owner March 25, 2025 07:05

product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Mar 25, 2025

surbhigarg92 reviewed Mar 25, 2025

View reviewed changes

surbhigarg92 previously approved these changes Mar 25, 2025

View reviewed changes

🦉 Updates from OwlBot post-processor

e73331f

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

surbhigarg92 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2025

refactor: sample comments

f09e627

skuruppu reviewed Mar 28, 2025

View reviewed changes

Merge branch 'main' into sample-snapshot-isolation

1c03bdf

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 1, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2025

alkatrivedi force-pushed the sample-snapshot-isolation branch from c292e3c to 2ee6b33 Compare April 1, 2025 05:21

refactor sample

82eb764

alkatrivedi force-pushed the sample-snapshot-isolation branch from 2ee6b33 to 82eb764 Compare April 2, 2025 04:28

🦉 Updates from OwlBot post-processor

470eb56

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

alkatrivedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2025

skuruppu reviewed Apr 7, 2025

View reviewed changes

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2025

alkatrivedi and others added 2 commits April 7, 2025 11:43

Merge branch 'main' into sample-snapshot-isolation

5772cb2

refactor: tests

0da8b77

alkatrivedi and others added 3 commits August 20, 2025 20:55

Merge branch 'main' into sample-snapshot-isolation

4274d0b

Merge branch 'main' into sample-snapshot-isolation

05150e7

change naming

14b2fd4

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025

alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025

gcf-owl-bot bot and others added 4 commits August 25, 2025 13:19

🦉 Updates from OwlBot post-processor

217b0a5

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

000122d

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'sample-snapshot-isolation' of https://github.com/google…

0a3d9cb

…apis/nodejs-spanner into sample-snapshot-isolation

Merge branch 'main' into sample-snapshot-isolation

185852f

surbhigarg92 previously approved these changes Sep 23, 2025

View reviewed changes

surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Sep 23, 2025

alkatrivedi dismissed surbhigarg92’s stale review via 166130e September 24, 2025 05:18

alkatrivedi added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed automerge Merge the pull request once unit tests and other checks pass. labels Sep 24, 2025

surbhigarg92 previously approved these changes Sep 24, 2025

View reviewed changes

alkatrivedi dismissed surbhigarg92’s stale review via 36566d0 September 24, 2025 06:16

alkatrivedi force-pushed the sample-snapshot-isolation branch from 166130e to 36566d0 Compare September 24, 2025 06:16

fix: samples-test

e107491

alkatrivedi force-pushed the sample-snapshot-isolation branch from ecc0c81 to e107491 Compare September 24, 2025 11:37

alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2025

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2025

surbhigarg92 approved these changes Sep 24, 2025

View reviewed changes

alkatrivedi merged commit c1d7138 into main Sep 24, 2025
23 of 25 checks passed

alkatrivedi deleted the sample-snapshot-isolation branch September 24, 2025 15:06

alkatrivedi removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 24, 2025

	const snapshotIsolationOptionsForRequest = {
	// The isolation level specified at the request level takes precedence over the isolation level configured at the client level.
	const snapshotIsolationOptionsForRequest = {

		__Usage:__


		`node snapshot-isolation.js <INSTANCE_ID> <DATABASE_ID> <PROJECT_ID>`

Conversation

alkatrivedi commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

generated-files-bot bot commented Mar 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alkatrivedi commented Mar 25, 2025 •

edited

Loading

snippet-bot bot commented Mar 25, 2025 •

edited

Loading