Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

docs: Samples and tests for Database Admin Client APIs#1986

Merged
gcf-merge-on-green[bot] merged 24 commits intogoogleapis:mainfrom
alkatrivedi:apis-admin-database
Feb 29, 2024
Merged

docs: Samples and tests for Database Admin Client APIs#1986
gcf-merge-on-green[bot] merged 24 commits intogoogleapis:mainfrom
alkatrivedi:apis-admin-database

Conversation

@alkatrivedi
Copy link
Copy Markdown
Contributor

@alkatrivedi alkatrivedi commented Jan 20, 2024

This PR contains sample files and their integration tests for the database admin client APIs.

@alkatrivedi alkatrivedi requested review from a team January 20, 2024 10:39
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Jan 20, 2024
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jan 20, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 20, 2024
olavloite
olavloite reviewed Jan 22, 2024
View reviewed changes
Comment thread samples/v2/database-create-with-default-leader.js Outdated
Comment thread samples/v2/database-create-with-default-leader.js Outdated
Comment thread samples/v2/database-create-with-default-leader.js Outdated
Comment thread samples/v2/database-create-with-encryption-key.js Outdated
Comment thread samples/v2/database-create-with-version-retention-period.js Outdated
Comment thread samples/v2/schema.js
Comment thread samples/v2/table-alter-with-foreign-key-delete-cascade
Comment thread samples/v2/table-alter-with-foreign-key-delete-cascade Outdated
Comment thread samples/v2/table-drop-foreign-key-constraint-delete-cascade.js
Comment thread system-test/spanner.ts Outdated
arpan14
arpan14 reviewed Feb 9, 2024
View reviewed changes
Comment thread samples/v2/add-and-drop-new-database-role.js
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
arpan14
arpan14 reviewed Feb 29, 2024
View reviewed changes
Comment thread samples/v2/add-and-drop-new-database-role.js Outdated
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 29, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@arpan14
Copy link
Copy Markdown

arpan14 commented Feb 29, 2024

LGTM, please make sure you correct the close() methods invocation before merging.

olavloite
olavloite approved these changes Feb 29, 2024
View reviewed changes
Comment thread samples/v2/add-and-drop-new-database-role.js Outdated
Comment thread samples/v2/database-update.js Outdated
Comment thread samples/v2/database-update.js Outdated
Comment thread samples/v2/database-update.js Outdated
Comment thread samples/v2/index-create.js
Comment thread samples/v2/table-drop-foreign-key-constraint-delete-cascade.js
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 29, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@alkatrivedi alkatrivedi added the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit f34a33a into googleapis:main Feb 29, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@alkatrivedi alkatrivedi deleted the apis-admin-database branch March 5, 2024 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@olavloite olavloite olavloite approved these changes

@arpan14 arpan14 arpan14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alkatrivedi @arpan14 @olavloite @yoshi-kokoro