This repository was archived by the owner on Jul 20, 2023. It is now read-only.
feat: deferred client initialization#69
Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom Mar 6, 2020
Merged
Conversation
alexander-fenster
added
the
automerge
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
===========================================
- Coverage 93.13% 17.23% -75.91%
===========================================
Files 20 20
Lines 4285 4375 +90
Branches 143 0 -143
===========================================
- Hits 3991 754 -3237
- Misses 292 3621 +3329
+ Partials 2 0 -2
Continue to review full report at Codecov.
|
bcoe
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes from googleapis/gapic-generator-typescript#317
that will move the asynchronous initialization and authentication from the client constructor
to an
initialize()method. This method will be automatically called when the first RPC callis performed.
The client library usage has not changed, there is no need to update any code.
If you want to make sure the client is authenticated before the first RPC call, you can do
manually before calling any client method.