Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

feat: Retail Tutorials. If create BQ table is requested, check if it exists and remove before creation#157

Merged
kweinmeister merged 6 commits intogoogleapis:mainfrom
t-karasova:patch-1
Apr 8, 2022
Merged

feat: Retail Tutorials. If create BQ table is requested, check if it exists and remove before creation#157
kweinmeister merged 6 commits intogoogleapis:mainfrom
t-karasova:patch-1

Conversation

@t-karasova
Copy link
Copy Markdown
Contributor

@t-karasova t-karasova commented Mar 15, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@t-karasova t-karasova requested a review from a team March 15, 2022 15:46
@product-auto-label product-auto-label Bot added the api: retail Issues related to the googleapis/nodejs-retail API. label Mar 15, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2022
@kweinmeister kweinmeister added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 21, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 21, 2022
@kweinmeister kweinmeister added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 22, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@kweinmeister kweinmeister requested a review from a team March 28, 2022 15:45
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 28, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
chenlei1216
chenlei1216 approved these changes Mar 29, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/test/get-products-list.test.js
@@ -1,43 +0,0 @@
// Copyright 2022 Google Inc. All Rights Reserved.
Copy link
Copy Markdown
Contributor

@chenlei1216 chenlei1216 Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the deletion intended or mistake?

Copy link
Copy Markdown
Contributor

@nmykhailets nmykhailets Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unnecessary test

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Apr 6, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 7, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 7, 2022
@kweinmeister kweinmeister merged commit 349e171 into googleapis:main Apr 8, 2022
@release-please release-please Bot mentioned this pull request Apr 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@nmykhailets nmykhailets nmykhailets left review comments

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: retail Issues related to the googleapis/nodejs-retail API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@t-karasova @chenlei1216 @kweinmeister @sofisl @nmykhailets @yoshi-kokoro @tkarasyova